[bug #66308] wcs.h: wrong CTYPE after converting

[Mohammad Akhlaghi]

Update of bug #66308 (group gnuastro):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #2:

Thanks a lot Giacomo! It has been merged as
[https://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=7a29bac4f63 Commit
7a29bac4f63].

I have to say that it took me a little while to understand the trick you
implemented in the loop! I always had problems in such cases because 'size_t'
is always positive and a check of 'i>0' would always pass. But your solution
was pretty smart and elegant! Nice job! I was impressed!

In such cases (when the code is not immediately obvious), put a nice
description in a comment on top of the respective line. As you see I have done
in the merged commit. Readability of the code is a core component of
[https://www.gnu.org/software/gnuastro/manual/html_node/Science-and-its-tools.html
Gnuastro's manifesto]. Of course, this doesn't mean that we should avoid
efficient programming constructs, it just means that we should describe them
thoroughly in comments ;-).

Thanks again for finding and fixing this problem and the very nice/impressive
solution.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?66308>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature