[bug #61007] Crash due to CFITSIO 4.0.0 version format change

[Mohammad Akhlaghi]

URL:
  <https://savannah.gnu.org/bugs/?61007>

                 Summary: Crash due to CFITSIO 4.0.0 version format change
                 Project: GNU Astronomy Utilities
            Submitted by: makhlaghi
            Submitted on: Tue 03 Aug 2021 07:42:07 PM BST
                Category: Installation
                Severity: 3 - Normal
              Item Group: Crash
                  Status: In Progress
                 Privacy: Public
             Assigned to: makhlaghi
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

>From version 4.0.0, CFITSIO has changed its version format. Before this, it
was a 2 digit number (like 3.49 or 3.48 and etc), but from major version 4, it
will have three digits! This change has been described in the What's new
<https://heasarc.gsfc.nasa.gov/FTP/software/fitsio/c/docs/changes.txt>, as
("Changed version numbering to 3-field format").

Until now, Gnuastro was assuming the old format and thus printing the version
as a floating point number. But this won't work for the new versioning format
of CFITSIO (which is no longer a floating point number) and will cause a crash
in Gnuastro: 


fits.c: In function ‘gal_fits_key_write_version_in_ptr’:
fits.c:2106:36: error: too many decimal points in number
   sprintf(cfitsioversion, "%-.2f", CFITSIO_VERSION);
                                    ^
Makefile:2329: recipe for target 'fits.lo' failed


I am working on this and will post a comment when the fix is implemented.

This bug was reported to me today independently by Vincenzo Testa and Zohreh
Ghaffari.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61007>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/