[bug #58455] Timezone calculation is not portable and uses flag instead of seconds

[Mohammad Akhlaghi]

Update of bug #58455 (project gnuastro):

                  Status:               Confirmed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #2:

This bug has been implemented and pushed
<http://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=2cf080196> to the
main repository.

Thanks again Alexey for reporting this bug. The problem was infact more
serious: the 'timezone' was not used for the current time, but for a different
time (in the headers of datasets, usually the time the datasets were
created).

While I was looking into the fix, I noticed that by simply subtracting
'timezone', the result of the same command would be different in different
seasons (when daylight-saving was active, there would a one-hour difference!).
But I was impressed that 'mktime' actually calculates the timezone of the
local system at the time that 'tp' points to, thus correcting this error.

So I am closing this bug, but it would be great if you could give it a final
try on FreeBSD and see if there is no more building problem. You can get the
most recent tarball (that now has this bug fixed) from this URL:
https://akhlaghi.org/gnuastro-latest.tar.lz

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58455>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/