[sr #110195] Google Summer of Code (GSoC) discussions

[Sachin Kumar Singh]

Follow-up Comment #9, sr #110195 (project gnuastro):

I've made the following changes in the following files but there are a few
doubts:

* I've made a macro `GAL_ARITHMETIC_OP_SIZE` in lib/arithmetic.h.

In lib/arithmetic.c:

* I've made a `size` function 

/* what should be the data type of the function. I've used  the general one
*/
static gal_data_t *
arithmetic_size (int operator, gal_data_t* input){
  size_t *dsize=input->dsize;

  if(operator)
  {
    // how to return return dsize for the required operand;
  }
  else
  {
    error(EXIT_FAILURE, 0, "%s: operator code %d not recognized",
            __func__, operator);
    // how to return EXIT_FAILURE or something like that.
  }
}


* Added `else if (!strcmp(string, "size"))
    { op=GAL_ARITHMETIC_OP_SIZE;              *num_operands=1;  }`

in gal_arithmetic_set_operator.

* Added `case GAL_ARITHMETIC_OP_SIZE:            return "size";` in
gal_arithmetic_operator_string.

* added 

    case GAL_ARITHMETIC_OP_SIZE:
      d1 = va_arg(va, gal_data_t *);
      out=arithmetic_size(operator, d1);


in `gal_arithmatic`.

I've another idea to use `gal_fits_key_read` but that seems to be an overkill
for this simple problem. But I'm open to any suggestions. 

What are other things I need to change and are the current changes right? What
else is to be done? What are the things I'm getting wrong? 

Any suggestion?

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/support/?110195>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/