[gnuastro-devel] [bug #49460] When check linking fails, the successful checks message should not be printed

[Mohammad Akhlaghi]

URL:
  <http://savannah.gnu.org/bugs/?49460>

                 Summary: When check linking fails, the successful checks
message should not be printed
                 Project: GNU Astronomy Utilities
            Submitted by: makhlaghi
            Submitted on: Fri 28 Oct 2016 01:47:11 AM JST
                Category: Installation
                Severity: 3 - Normal
              Item Group: Crash
                  Status: Postponed
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The checks also include compiling programs with Gnuastro's library and running
them. However, when there is an error in the creation of the executable
(linking in the example below), the message that all tests have passed is
apparently still printed. 

The example below is related to bug #49459, kindly reported by Antonio Diaz
Diaz.

In such cases that message should not be printed.


make[2]: Entering directory `/home/build/gnuastro-0.2/tests'
make  versioncpp arraymanip multithread
make[3]: Entering directory `/home/build/gnuastro-0.2/tests'
depbase=`echo lib/versioncpp.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
g++ -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\"
-I../lib   -g -O2 -MT lib/versioncpp.o -MD -MP -MF $depbase.Tpo -c -o
lib/versioncpp.o lib/versioncpp.cpp &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CXX   --mode=link g++  -g -O2  -L../lib  -pthread -o
versioncpp lib/versioncpp.o -lgnuastro -ljpeg -lwcs -lcfitsio -lgsl -lgslcblas
-lm 
libtool: link: g++ -g -O2 -pthread -o .libs/versioncpp lib/versioncpp.o 
-L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so
/usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath
-Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to
`rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [versioncpp] Error 1
depbase=`echo lib/arraymanip.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\"
-I../lib   -Wall -O3  -pthread -MT lib/arraymanip.o -MD -MP -MF $depbase.Tpo
-c -o lib/arraymanip.o lib/arraymanip.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -Wall -O3  -pthread  -L../lib 
-pthread -o arraymanip lib/arraymanip.o -lgnuastro -ljpeg -lwcs -lcfitsio
-lgsl -lgslcblas -lm 
libtool: link: gcc -Wall -O3 -pthread -pthread -o .libs/arraymanip
lib/arraymanip.o  -L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so
/usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath
-Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to
`rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [arraymanip] Error 1
depbase=`echo lib/multithread.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I..  -I../lib -DSYSCONFIG_DIR=\"/usr/local/etc\"
-I../lib   -Wall -O3  -pthread -MT lib/multithread.o -MD -MP -MF $depbase.Tpo
-c -o lib/multithread.o lib/multithread.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool  --tag=CC   --mode=link gcc  -Wall -O3  -pthread  -L../lib 
-pthread -o multithread lib/multithread.o -lgnuastro -ljpeg -lwcs -lcfitsio
-lgsl -lgslcblas -lm 
libtool: link: gcc -Wall -O3 -pthread -pthread -o .libs/multithread
lib/multithread.o  -L../lib /home/build/gnuastro-0.2/lib/.libs/libgnuastro.so
/usr/lib64/libjpeg.so -lwcs -lcfitsio -lgsl -lgslcblas -lm -pthread -Wl,-rpath
-Wl,/usr/lib64
/home/build/gnuastro-0.2/lib/.libs/libgnuastro.so: undefined reference to
`rpl_malloc'
collect2: error: ld returned 1 exit status
make[3]: *** [multithread] Error 1
make[3]: Leaving directory `/home/build/gnuastro-0.2/tests'
make[2]: *** [check-am] Error 2
make[2]: Target `check' not remade because of errors.
make[2]: Leaving directory `/home/build/gnuastro-0.2/tests'
make[2]: Entering directory `/home/build/gnuastro-0.2'
make  check-local
make[3]: Entering directory `/home/build/gnuastro-0.2'

===================================================================
===================================================================
Your build of Gnuastro 0.2 didn't fail on any tests.
To install Gnuastro, please run the commands below:

(NOTE: As the user antonio, you don't have writing permissions
in "/usr/local". To install Gnuastro there, you must get 
privileges first, as described below. If you can't, configure 
Gnuastro again, for example: "./configure --prefix ~/.local".)

    sudo make install
or
    su
    make install
    exit

(The following "Leaving directory" notices can be ignored.)
===================================================================
===================================================================

make[3]: Leaving directory `/home/build/gnuastro-0.2'
make[2]: Leaving directory `/home/build/gnuastro-0.2'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/build/gnuastro-0.2'
make: *** [check] Error 2





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49460>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/