[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnuastro-commits] master 2b0b6294 56/69: PSF scripts: fixed two FAILS d
From: |
Mohammad Akhlaghi |
Subject: |
[gnuastro-commits] master 2b0b6294 56/69: PSF scripts: fixed two FAILS during make checks |
Date: |
Wed, 26 Jan 2022 12:39:15 -0500 (EST) |
branch: master
commit 2b0b6294f804fdaa6d05663d99fdb17dad71b91c
Author: Raul Infante-Sainz <infantesainz@gmail.com>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>
PSF scripts: fixed two FAILS during make checks
Until this commit, there were two PSF scripts that failed during the make
check steps. For the 'psf-create-junction' script the problem was that the
variable of the inner image name was not the correct one: it was 'psf' but
should be 'core'. For the 'psf-create-select-stars' the problem was that
when using the option '--range' in Table, the separator should be commas
',', however, semicolons ':' were used instead.
With this commit, these bugs have been corrected. Now the make checks run
without any problem for this two scripts.
---
bin/script/psf-create-junction.in | 2 +-
bin/script/psf-create-select-stars.in | 10 +++++-----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/bin/script/psf-create-junction.in
b/bin/script/psf-create-junction.in
index 9982ae00..524e054f 100644
--- a/bin/script/psf-create-junction.in
+++ b/bin/script/psf-create-junction.in
@@ -354,7 +354,7 @@ ycenter=$(astarithmetic $yaxis 2 / --quiet)
# image. So, the center of the PSF is computed here from the size of the
# PSF image along the two axis (in pixels). Dimension values are computed
# as described above.
-psfaxises=$(astfits $psf --hdu=$psfhdu --quiet \
+psfaxises=$(astfits $core --hdu=$corehdu --quiet \
--keyvalue ZNAXIS1,ZNAXIS2,NAXIS1,NAXIS2)
psfnaxises=$(echo $psfaxises \
| sed 's/n\/a//g' \
diff --git a/bin/script/psf-create-select-stars.in
b/bin/script/psf-create-select-stars.in
index 9ab27c54..b7d70e9d 100755
--- a/bin/script/psf-create-select-stars.in
+++ b/bin/script/psf-create-select-stars.in
@@ -463,9 +463,9 @@ if [ x"$catalog" != x ]; then
echo "External Cataloge already exists "
else
# Select stars with magnitude between minimum to maximum.
- asttable $catalog --range=$field,$minmag:$maxmag --sort=$field \
- --range=$racolumn,$minraimg:$maxraimg \
- --range=$deccolumn,$mindecimg:$maxdecimg \
+ asttable $catalog --range=$field,$minmag,$maxmag --sort=$field \
+ --range=$racolumn,$minraimg,$maxraimg \
+ --range=$deccolumn,$mindecimg,$maxdecimg \
--output=$catalog_magfiltered $quiet
# At first check and if there are no stars in the range of
magnitude
@@ -487,7 +487,7 @@ else
else
# Download the catalog with the necessary parameters.
astquery $dataset --output=$catalog_magfiltered --overlapwith=$inputs
--hdu=$hdu \
- --column=$columnquery --range=$field,$minmag:$maxmag \
+ --column=$columnquery --range=$field,$minmag,$maxmag \
--sort=$field $quiet
fi
fi
@@ -505,7 +505,7 @@ fi
goodparallax=$tmpdir/parallax-good.fits
if [ x"$parallaxanderrorcolumn" != x ]; then
asttable $catalog_magfiltered -c$racolumn,$deccolumn -c$field \
- --range=$field,$minmag:$maxmag --colinfoinstdout --noblank=4 \
+ --range=$field,$minmag,$maxmag --colinfoinstdout --noblank=4 \
-c'arith '$parallax' '$parallax' abs \
'$parallax_error' 3 x lt nan where ' \
| asttable -c$racolumn,$deccolumn -c$field --output=$goodparallax
$quiet
- [gnuastro-commits] master ca8fc03a 55/69: PSF scripts: getting proper NAXIS values when data is compressed as .fz, (continued)
- [gnuastro-commits] master ca8fc03a 55/69: PSF scripts: getting proper NAXIS values when data is compressed as .fz, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 5eac0cea 40/69: Book: polishing the description of the PSF select-stars script, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master d99fc9df 60/69: PSF select-stars: add new option for selecting more bright stars, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 69a2e6ee 54/69: Book: correct some comments in the psf-create-select-stars, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master f42832f8 23/69: PSF stamp: allowingto use a position angle and axis ratio, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 2894b35a 32/69: PSF model: including the make check step for two PSF scripts, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master aae0d156 64/69: PSF tutorial: running of Segment on saturated images added, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 5fdd3a4a 31/69: PSF create: including the make check step for two PSF scripts, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master d6e6f9da 47/69: PSF flux-factor: correct the indentation, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 809be22b 67/69: Book: PSF construction tutorial, completed until the outer part, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 2b0b6294 56/69: PSF scripts: fixed two FAILS during make checks,
Mohammad Akhlaghi <=
- [gnuastro-commits] master f2a74d83 30/69: Book: fixing references and labels for the PSF scripts information, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master cf6335a6 18/69: PSF stamp: enabling the use of sigma-clip parameters, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 00b08df2 28/69: PSF stamp: add --saturation option for masking the saturated pixels, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 2718494e 19/69: PSF stamp: allowing to run the script without making normalization, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master da6eea59 33/69: Scripts: changing 'wcstoimg' to 'wcs-to-img' in several scripts, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 50fd424f 66/69: PSF tutorial: adding information to choose proper --normradii values, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master 86ac2dd1 42/69: PSF select-stars: corrected bug in checking the catalog-image overlap, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master cf58a078 62/69: PSF select-stars: give the default value to the two variables, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master db2d55be 37/69: PSF select-stars: changing some variable names to follow conventions, Mohammad Akhlaghi, 2022/01/26
- [gnuastro-commits] master cd14a366 44/69: PSF select-stars: including the make check step for this script, Mohammad Akhlaghi, 2022/01/26