[gnuastro-commits] master 86a4db4b: Configuration: no modification in LDFLAGS for library checks

[Mohammad Akhlaghi]

branch: master
commit 86a4db4b8367a1729e115236b3891f4dbc5e8878
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    Configuration: no modification in LDFLAGS for library checks
    
    Until now (since commit 1ac084b4), the LDFLAGS library was being
    temporarily modified before checking for high-level features of the
    available libraries (for example if 'pthreads' has the barrier feature, or
    if WCSLIB has a version function and etc). On some systems (for example
    Ubuntu 20.04), this would cause crash during the 'make' step (and in
    particular because of the conflicting definitions of the pthread's barrier
    feature!).
    
    This particular change in LDFLAGS was not the cause of the problem behind
    commit 1ac084b4 (that was to do with 'LIBS' and Gnulib!). It was just a
    change that didn't cause a conflict on my system, so I thought it should be
    fine (given the similar change that I did to fix the Gnulib problem).
    
    With this commit, that particular part of temporarily changing LDFLAGS in
    commit 1ac084b4 is now removed from the configure time checks and this
    fixed the problem.
    
    This issue was reported by Raul Infante-Sainz.
---
 configure.ac | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/configure.ac b/configure.ac
index 117c291f..d192a000 100644
--- a/configure.ac
+++ b/configure.ac
@@ -500,19 +500,6 @@ AS_IF([test "x$enable_shared" = "xno"],
 # causes possibly different versions of the libraries to be read.
 
 
-# Set a new 'LDFLAGS' variable to use in these checks. The reason is that
-# 'LDFLAGS' is placed in the compile command _before_ the library (e.g.,
-# 'libwcs'). However, 'LDADD' (that we have been actively setting above!)
-# is placed _after_ the library in the compile command! As a result, when
-# 'LDADD' includes a '-L/path/to/library', it will only be seen after the
-# library (and therefore will be useless!).
-#
-# This is only necessary during the checking of the libraries at configure
-# time (here) because of the peculiar features of 'AC_LIB_HAVE_LINKFLAGS'
-# (which may use '-l' or '-L' depending on the situtation, which is very
-# good during checks.).
-orig_LDFLAGS="$LDFLAGS"
-LDFLAGS="$LDFLAGS $LDADD"
 
 
 # GSL's 'gsl_interp_steffen' isn't a function. So we'll need to use
@@ -588,12 +575,6 @@ AC_DEFINE_UNQUOTED([GAL_CONFIG_HAVE_PTHREAD_BARRIER], 
[$has_pthread_barrier],
 AC_SUBST(HAVE_PTHREAD_BARRIER, [$has_pthread_barrier])
 
 
-# Reset LDFLAGS (see the comments above 'orig_LDFLAGS'). This SHOULD BE
-# PLACED AFTER ALL LIBRARIES ARE CHECKED.
-LDFLAGS="$orig_LDFLAGS"
-# ---------------------------------End of library checks
-
-