gnuastro-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnuastro-commits] master b299833: Radial profile: standard deviation in


From: Mohammad Akhlaghi
Subject: [gnuastro-commits] master b299833: Radial profile: standard deviation input properly passed to MakeCatalog
Date: Mon, 14 Jun 2021 08:06:29 -0400 (EDT)

branch: master
commit b299833a0af05292dfad717c2af55b2dd82f3f5e
Author: Zahra Sharbaf <zahra.sharbaf2@gmail.com>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    Radial profile: standard deviation input properly passed to MakeCatalog
    
    Until now, the standard deviation input image was considered in the section
    that inputs data sets cropped in the asked radius. However, the variable
    that defined its usage for the MakeCatalog call was not given a value! As a
    result, the standard deviation image would not be used in the catalog
    production and all error-related measurements like the magnitude or
    brightness errors or signal-to-noise ratio would be NaN.
    
    With this commit, for all possibilities of having a standard deviation (as
    a single number or file), a value has been defined for the standard
    deviation cropped/warped file or the single digit.
    
    This fixes Bug #60776.
---
 NEWS                         |  4 +++-
 bin/script/radial-profile.in | 29 +++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/NEWS b/NEWS
index 2ff621f..015476c 100644
--- a/NEWS
+++ b/NEWS
@@ -13,8 +13,10 @@ See the end of the file for license conditions.
 
 ** Bugs fixed
   bug #60725: MakeCatalog doesn't put comment on --halfsumsb column.
+  bug #60776: Radial profile script not using standard deviation image,
+              this bug was fixed by Zahra Sharbaf.
   bug #60778: Brightness error not NaN when all STD pixels are blank,
-              This bug was reported by Zahra Sharbaf.
+              this bug was reported by Zahra Sharbaf.
 
 
 
diff --git a/bin/script/radial-profile.in b/bin/script/radial-profile.in
index 38f9814..39cd6de 100755
--- a/bin/script/radial-profile.in
+++ b/bin/script/radial-profile.in
@@ -477,6 +477,35 @@ fi
 
 
 
+# Define the standard deviation option to MakeCatalog
+# ---------------------------------------------------
+#
+# The standard deviation input can be a file or a single number. If it is a
+# file, it has been cropped or warped (in the oversample scenario) in the
+# previous blocks of the code. In this part, we set the option string to
+# pass onto MakeCatalog in all possibilities (being a single number, a file
+# or not defined).
+#
+# If the user has not given 'instd', then just pass an empty string to
+# MakeCatalog.
+if [ x"$instd" = x ]; then
+    finalinstd=""
+else
+     # When 'instd' is a file, put the 'valuesstd' as the option value
+     # (which has been warped/cropped and created in the previous section).
+     if [ -f "$instd" ]; then
+         finalinstd="--instd=$valuesstd"
+
+     # When 'instd' is a number, simply give the number as the value.
+     else
+         finalinstd="--instd=$instd"
+     fi
+fi
+
+
+
+
+
 # Generate the apertures image
 # ----------------------------
 #



reply via email to

[Prev in Thread] Current Thread [Next in Thread]