[gnuastro-commits] master 19da8cf: MakeCatalog: comments added for --halfsumsb and other columns

[Mohammad Akhlaghi]

branch: master
commit 19da8cf9afd29c405933e13379a3fcb8e4095341
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    MakeCatalog: comments added for --halfsumsb and other columns
    
    Until now, when the '--halfsumsb' column was requested from MakeCatalog
    that also includes measuring clumps, the output column didn't have any
    comments in the metadata. While looking at the code, I found that the
    source of the problem is that the 'ccomment' (clump comment) variable was
    not being set for this column!
    
    With this commit 'ccomment' is given the same value as 'ocomment' (object
    comments) like all the other columns that have the same description between
    objects and clumps. After doing so, I inspected all the existing columns
    and noticed that this was happening for a few more columns also: '--fwhm',
    '--halfmaxradius', '--halfsumradius', '--fracmaxradius1',
    '--fracmaxradius2', '--fracmaxsum1', '--fracmaxsum2'.
    
    In the process, I also improved the description of '--halfsumsb' and
    '--halfmaxsb' to be more clear (they didn't contain the term "Surface
    brightness"!
---
 NEWS                    | 1 +
 bin/mkcatalog/columns.c | 8 +++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 15f65fd..70d8c03 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,7 @@ See the end of the file for license conditions.
 ** Changed features
 
 ** Bugs fixed
+  bug #60725: MakeCatalog doesn't put comment on --halfsumsb column.
 
 
 
diff --git a/bin/mkcatalog/columns.c b/bin/mkcatalog/columns.c
index d6d0469..34aa0c1 100644
--- a/bin/mkcatalog/columns.c
+++ b/bin/mkcatalog/columns.c
@@ -1780,7 +1780,7 @@ columns_define_alloc(struct mkcatalogparams *p)
         case UI_KEY_HALFMAXSB:
           name           = "HALF_MAX_SB";
           unit           = "mag/arcsec^2";
-          ocomment       = "Brightness within half the maximum, divided by its 
area.";
+          ocomment       = "Surface brightness for pixels above half the 
maximum.";
           ccomment       = ocomment;
           otype          = GAL_TYPE_FLOAT32;
           ctype          = GAL_TYPE_FLOAT32;
@@ -1795,7 +1795,8 @@ columns_define_alloc(struct mkcatalogparams *p)
         case UI_KEY_HALFSUMSB:
           name           = "HALF_SUM_SB";
           unit           = "mag/arcsec^2";
-          ocomment       = "Half the brightness, divided by its area.";
+          ocomment       = "Surface brightness for pixels above half the sum 
of all labeled pixels.";
+          ccomment       = ocomment;
           otype          = GAL_TYPE_FLOAT32;
           ctype          = GAL_TYPE_FLOAT32;
           disp_fmt       = GAL_TABLE_DISPLAY_FMT_GENERAL;
@@ -1812,7 +1813,6 @@ columns_define_alloc(struct mkcatalogparams *p)
                              ? "FRAC_MAX_SUM_1"
                              : "FRAC_MAX_SUM_2" );
           unit           = MKCATALOG_NO_UNIT;
-          ccomment       = ocomment;
           otype          = GAL_TYPE_FLOAT32;
           ctype          = GAL_TYPE_FLOAT32;
           disp_fmt       = 0;
@@ -1830,6 +1830,7 @@ columns_define_alloc(struct mkcatalogparams *p)
               ocomment = "Sum of pixels brighter than 2nd fraction of 
maximum.";
               oiflag[ OCOL_FRACMAX2SUM ] = ciflag[ CCOL_FRACMAX2SUM ] = 1;
             }
+          ccomment = ocomment;
           break;
 
         case UI_KEY_FRACMAXAREA1:
@@ -1906,6 +1907,7 @@ columns_define_alloc(struct mkcatalogparams *p)
               ocomment = "Radius derived from area of 2nd fraction of 
maximum.";
               break;
             }
+          ccomment = ocomment;
           break;
 
         default: