[gnuastro-commits] master 6f85919 060/113: Connectivity of 2, for filling pseudo-detection holes in 3D

[Mohammad Akhlaghi]

branch: master
commit 6f859193bea90180be86c53dfbfb38d0631b4623
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>

    Connectivity of 2, for filling pseudo-detection holes in 3D
    
    Until now, the number of dimensions (strongest connectivity) was used to
    fill holes in the pseudo-detections. For 2D, the strongest connectivity (2)
    is fine. But for 3D, the strongest connectivity is too strong and will not
    be too useful for diffuse signal. So for 3D, we are now using the
    second-strongest connectivity of 2 (numerically: same as the 2D case).
---
 bin/noisechisel/detection.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/bin/noisechisel/detection.c b/bin/noisechisel/detection.c
index 24b08d8..5bb62cc 100644
--- a/bin/noisechisel/detection.c
+++ b/bin/noisechisel/detection.c
@@ -279,8 +279,14 @@ detection_fill_holes_open(void *in_prm)
       gal_data_copy_to_allocated(tile, copy);
 
       /* Fill the holes in this tile: holes with maximal connectivity means
-         that they are most strongly bounded. */
-      gal_binary_holes_fill(copy, copy->ndim, -1);
+         that they are most strongly bounded.
+
+         IMPORTANT NOTE: For 2D, the strongest connectivity (2) is
+         fine. But for 3D, the strongest connectivity is too strong and
+         will not be too useful for diffuse signal. So for 3D, we are now
+         using the second-strongest connectivity of 2 (numerically: same as
+         the 2D case). */
+      gal_binary_holes_fill(copy, 2, -1);
       if(fho_prm->step==1)
         {
           detection_write_in_large(tile, copy);