Re: gnokii-0.6.30 patch

[Alexander V. Lukyanov]

On Wed, Oct 19, 2011 at 10:28:51AM +0200, Pawel Kot wrote:
> --- gnokii-0.6.30/common/phones/nk6510.c      2011-01-23 17:27:32.000000000 
> +0300
> +++ gnokii-0.6.30+/common/phones/nk6510.c     2011-03-11 14:02:25.000000000 
> +0300
> +             if(!data->message_center)
> +                     data->message_center = calloc(1, 
> sizeof(data->message_center[0]));
> 
> No, I want to avoid it. If (!data->message_center) it should exit with
> error in this place. It is a responsibility of the caller to allocate
> it.

Ok, then the caller should be fixed.

>      free (dt->message_center);
> +    dt->message_center = 0;
> 
> I'd prefer NULL instead of 0. But that should not matter actually. We
> allocate the structure unconditionally.
> 
>    free (dt->sms->reference);
> +  dt->sms->reference=0;
> +  dt->sms->parts=0;
>    free (dt);
> 
> Does not make sense as we free() it right after.

It's not quite so. dt->sms is not free'd.

> Can you please disclose your name for the changelogging purposes?

Sure, I have sent original mail from root by accident.

-- 
   Alexander.