Re: Add

[Bastien Nocera]

Pawel Kot <gnokii <at> gmail.com> writes:

Hey Pawel,

> On 7/3/07, Bastien Nocera <hadess <at> hadess.net> wrote:
<snip>
> And is it case sensitive?

No idea, feel free to add an implementation of strcasestr, for non-GNU systems
to use.
Updated patch at:
http://people.redhat.com/bnocera/gnokii-0.6.16-at-handle-sms-status-2.patch

> > I didn't manage to test it properly on my Nokia in AT mode, as it lies
> > about the number of SMSes in its different folders.
> 
> Well, Nokia AT mode doesn't support folders. :)

Arf. Well, it first reports 20 messages available. Then switching folders
reports 130 ones available.

> > I'm trying to fix:
> > http://bugzilla.gnome.org/show_bug.cgi?id=330773
> 
> But the patch is for the quite different thing...

It's part of it. The bug is that phones using the AT driver can't find new
messages. One reason is that they don't see new messages reported in
GN_OP_GetSMSStatus. The other problem is that they don't report unread messages
as being unread. The provided patch fixes the second, while I worked around the
first one by checking for a different number of messages in the folder.

> > and I noticed that only some Nokia drivers implemented GN_OP_OnSMS or
> > GN_OP_PollSMS. Would it be interesting to have CNMI support in the
> > generic AT driver?
> 
> Sure!

I have no idea how it's supposed to work though. Do you have some definite
documentation available on that? The only thing I have is the Mototola g20 docs.

> > PS: current gnokii CVS HEAD crashes for me when using the AT driver,
> > straight after an ATZ. Anyone seeing that?
> 
> Nope. Just tested over rfcomm. Any details?

$ ./gnokii --identify
GNOKII Version 0.6.17cvs
LOG: debug mask is 0x1
Config read from file /home/hadess/.gnokiirc.
phone instance config:
model: 6230
port_device: 00:12:D2:79:B7:33
connection_type: 5
init_length: 0
serial_baudrate: 19200
serial_write_usleep: -1
hardware_handshake: 0
require_dcd: 0
smsc_timeout: 100
connect_script: 
disconnect_script: 
rfcomm_cn: 1
sm_retry: off
Connecting
Serial device: opening device 00:12:XX:XX:XX:XX
Getting model...
Message sent: 0x1b / 0x0006
00 01 00 07 01 00                               |                 
Segmentation fault

Same thing happens with the AT driver. BT of the above crash:
(gdb) bt
#0  0x000000000062d5e0 in ?? ()
#1  0x00002aaaaaae45bc in NK6510_GetModel (data=0x7fff613ff320, state=0x622810)
at nk6510.c:613
#2  0x00002aaaaaae8253 in NK6510_Functions (op=<value optimized out>,
data=0x7fff613ff320, state=0x622810) at nk6510.c:261
#3  0x00002aaaaaae9294 in NK6510_Functions (op=<value optimized out>,
data=<value optimized out>, state=0x622810) at nk6510.c:501
#4  0x00002aaaaaabf7f6 in register_driver (driver=0x2aaaaad205e0, 
model=0x622814
"6230", setupmodel=<value optimized out>, sm=0x622810) at gsm-api.c:114
#5  0x00002aaaaaabf993 in gn_gsm_initialise (sm=0x622810) at gsm-api.c:149
#6  0x00002aaaaaabf5f8 in gn_lib_phone_open (state=0x622810) at 
libfunctions.c:137
#7  0x0000000000402e91 in parse_options (argc=2, argv=0x7fff61409908) at
gnokii.c:322
#8  0x0000000000403682 in main (argc=2, argv=0x7fff61409908) at gnokii.c:1054

And valgrind says:
==12078== Invalid read of size 1
==12078==    at 0x4EBAD90: ???
==12078==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==12078== 
==12078== Process terminating with default action of signal 11 (SIGSEGV)
==12078==  Access not within mapped region at address 0x0
==12078==    at 0x4EBAD90: ???

I think the function tables is getting overwritten somehow. This doesn't happen
with 0.6.16.

PS: Please CC: me on the replies, as I'm not subscribed.