[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-516-gc48f1b9

[Daniele Forsi]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  c48f1b9b1a42e90a159e0ff54305c5e9a1990e30 (commit)
      from  cc0992d7b3e0408521c5fa77923961bf5a01f5e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=c48f1b9b1a42e90a159e0ff54305c5e9a1990e30


commit c48f1b9b1a42e90a159e0ff54305c5e9a1990e30
Author: Daniele Forsi <address@hidden>
Date:   Mon Apr 29 13:57:15 2013 +0200

    Again NUL-terminate the buffer in every case
    
    fread() doesn't terminate it.
    Fixes:
    ==31337== Conditional jump or move depends on uninitialised value(s)
    ==31337==    at 0x44072F4: vfprintf (vfprintf.c:1623)
    ==31337==    by 0x4428DCF: vsnprintf (vsnprintf.c:120)
    ==31337==    by 0x440CED1: snprintf (snprintf.c:35)
    ==31337==    by 0x805DE41: readtext (gnokii-utils.c:144)
    ==31337==  Uninitialised value was created by a stack allocation
    ==31337==    at 0x805DDA0: readtext (gnokii-utils.c:116)
    ==31337==

diff --git a/gnokii/gnokii-utils.c b/gnokii/gnokii-utils.c
index 7637af0..bdf8716 100644
--- a/gnokii/gnokii-utils.c
+++ b/gnokii/gnokii-utils.c
@@ -138,8 +138,8 @@ gn_error readtext(gn_sms_user_data *udata)
                        fprintf(stderr, _("Input too long! (%d, maximum is 
%d)\n"), chars_read, (int)(sizeof(udata->u.text) - 1));
                        return GN_ERR_ENTRYTOOLONG;
                }
-               message_buffer[chars_read] = '\0';
        }
+       message_buffer[chars_read] = '\0';
 
        udata->length = snprintf(udata->u.text, sizeof(udata->u.text), "%s", 
message_buffer);
 

-----------------------------------------------------------------------

Summary of changes:
 gnokii/gnokii-utils.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs