gnokii-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-45


From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-457-g00f85fe
Date: Mon, 15 Apr 2013 12:40:36 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  00f85fef62c77061b655fb813fc4037d79344ffa (commit)
       via  3bbf9c753f77af6685476da488dc1859a1ba48f4 (commit)
      from  d5088259673ab4c6e5769f16148d8c49494a748a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=00f85fef62c77061b655fb813fc4037d79344ffa


commit 00f85fef62c77061b655fb813fc4037d79344ffa
Author: Daniele Forsi <address@hidden>
Date:   Mon Apr 15 14:34:18 2013 +0200

    Fix: Value stored to 'error' is never read
    
    Error found with scan-build.

diff --git a/common/phones/nk6510.c b/common/phones/nk6510.c
index 7577b1c..5e50add 100644
--- a/common/phones/nk6510.c
+++ b/common/phones/nk6510.c
@@ -1360,6 +1360,8 @@ static gn_error NK6510_GetSMSFolderStatus(gn_data *data, 
struct gn_statemachine
                req[4] = 0x01;
                if (sm_message_send(10, NK6510_MSG_FOLDER, req, state)) return 
GN_ERR_NOTREADY;
                error = sm_block(NK6510_MSG_FOLDER, data, state);
+               if (error != GN_ERR_NONE)
+                       return error;
 
                /* FIXME: make it dynamic buffer */
                if (phone.number + data->sms_folder->number > 
GN_SMS_MESSAGE_MAX_NUMBER) {
@@ -1579,6 +1581,8 @@ static gn_error NK6510_GetSMS(gn_data *data, struct 
gn_statemachine *state)
        dprintf("Getting SMS from location %d\n", data->raw_sms->number);
 
        error = NK6510_GetSMSMessageStatus(data, state);
+       if (error != GN_ERR_NONE)
+               return error;
 
        if ((data->raw_sms->memory_type == GN_MT_IN) || 
(data->raw_sms->memory_type == GN_MT_OU)) {
                if (data->raw_sms->number > 1024) {

http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=3bbf9c753f77af6685476da488dc1859a1ba48f4


commit 00f85fef62c77061b655fb813fc4037d79344ffa
Author: Daniele Forsi <address@hidden>
Date:   Mon Apr 15 14:34:18 2013 +0200

    Fix: Value stored to 'error' is never read
    
    Error found with scan-build.

diff --git a/common/phones/nk6510.c b/common/phones/nk6510.c
index 7577b1c..5e50add 100644
--- a/common/phones/nk6510.c
+++ b/common/phones/nk6510.c
@@ -1360,6 +1360,8 @@ static gn_error NK6510_GetSMSFolderStatus(gn_data *data, 
struct gn_statemachine
                req[4] = 0x01;
                if (sm_message_send(10, NK6510_MSG_FOLDER, req, state)) return 
GN_ERR_NOTREADY;
                error = sm_block(NK6510_MSG_FOLDER, data, state);
+               if (error != GN_ERR_NONE)
+                       return error;
 
                /* FIXME: make it dynamic buffer */
                if (phone.number + data->sms_folder->number > 
GN_SMS_MESSAGE_MAX_NUMBER) {
@@ -1579,6 +1581,8 @@ static gn_error NK6510_GetSMS(gn_data *data, struct 
gn_statemachine *state)
        dprintf("Getting SMS from location %d\n", data->raw_sms->number);
 
        error = NK6510_GetSMSMessageStatus(data, state);
+       if (error != GN_ERR_NONE)
+               return error;
 
        if ((data->raw_sms->memory_type == GN_MT_IN) || 
(data->raw_sms->memory_type == GN_MT_OU)) {
                if (data->raw_sms->number > 1024) {

-----------------------------------------------------------------------

Summary of changes:
 common/phones/nk6510.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs



reply via email to

[Prev in Thread] Current Thread [Next in Thread]