[SCM] libgnokii and core programs branch, master, updated. rel_0_6_29-440-g31c926e

[Daniele Forsi]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  31c926e8fe862d2f8e33b353b436b103fc73ac85 (commit)
      from  563b79f53042ad7050253826a2af2dda707291f9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=31c926e8fe862d2f8e33b353b436b103fc73ac85


commit 31c926e8fe862d2f8e33b353b436b103fc73ac85
Author: Daniele Forsi <address@hidden>
Date:   Mon Mar 4 23:57:19 2013 +0100

    Fix buffer overflow
    
    From man strncat: If src contains n or more bytes, strncat() writes
    n+1 bytes to dest (n from src plus the terminating null byte).
    Bug and fix by clang:
    
http://clang.debian.net/logs/2013-01-28/gnokii_0.6.30+dfsg-1_unstable_clang.log

diff --git a/common/data/virtmodem.c b/common/data/virtmodem.c
index 33828cd..9a94d36 100644
--- a/common/data/virtmodem.c
+++ b/common/data/virtmodem.c
@@ -338,12 +338,12 @@ static int VM_PtySetup(const char *bindir)
 
        if (bindir) {
                strncpy(mgnokiidev, bindir, sizeof(mgnokiidev));
-               strncat(mgnokiidev, "/", sizeof(mgnokiidev) - 
strlen(mgnokiidev));
+               strncat(mgnokiidev, "/", sizeof(mgnokiidev) - 
strlen(mgnokiidev) - 1);
        } else {
                mgnokiidev[0] = 0;
        }
 
-       strncat(mgnokiidev, "mgnokiidev", sizeof(mgnokiidev) - 
strlen(mgnokiidev));
+       strncat(mgnokiidev, "mgnokiidev", sizeof(mgnokiidev) - 
strlen(mgnokiidev) - 1);
 
        if (access(mgnokiidev, X_OK) != 0) {
                fprintf(stderr, _("Cannot access %s, check the bindir in your 
config file!\n"), mgnokiidev);

-----------------------------------------------------------------------

Summary of changes:
 common/data/virtmodem.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs