gnokii-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[SCM] libgnokii and core programs branch, master, updated. rel_0_6_28-17


From: Daniele Forsi
Subject: [SCM] libgnokii and core programs branch, master, updated. rel_0_6_28-179-g77ab743
Date: Wed, 10 Mar 2010 18:05:41 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "libgnokii and core programs".

The branch, master has been updated
       via  77ab7437b9fb03a04fd7e9bb1ba385be650e3aa0 (commit)
      from  3ae34e4844305799f416230dc1521abd04c5f6d9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/gnokii.git/commit/?id=77ab7437b9fb03a04fd7e9bb1ba385be650e3aa0


commit 77ab7437b9fb03a04fd7e9bb1ba385be650e3aa0
Author: Daniele Forsi <address@hidden>
Date:   Wed Mar 10 18:54:44 2010 +0100

    Fix random segfault when using --deletecalendarnote
    
    Need to clear the calnote_list else random values in 
data->calnote_list->last
    could lead to an array out of bounds access.
    Output from gdb:
    Read 10721228 of 0 calendar entries
    
    Program received signal SIGSEGV, Segmentation fault.
    0x080a3c2c in NK6510_GetCalendarNotesInfo (data=0xb7e3f39c, 
state=0xb7e3f008) at ../../../gnokii/common/phones/nk6510.c:3614
    3614                        req[8] = 
data->calnote_list->location[LAST_INDEX] / 256;
    (gdb) backtrace

diff --git a/ChangeLog b/ChangeLog
index b7f1f37..548676b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -20,6 +20,8 @@
                                                         (Paweł Kot)
     o show reference number also for sendlogo() and sendringtone()
                                                     (Daniele Forsi)
+    o fix random segfault when using --deletecalendarnote
+                                                    (Daniele Forsi)
  * nk6510 driver updates
     o support SMS memory OUS on phones prior to Series 40 3rd
                                          (Paweł Kot, Daniele Forsi)
diff --git a/gnokii/gnokii-calendar.c b/gnokii/gnokii-calendar.c
index a1ca3b9..ee41ba9 100644
--- a/gnokii/gnokii-calendar.c
+++ b/gnokii/gnokii-calendar.c
@@ -337,6 +337,7 @@ gn_error deletecalendarnote(int argc, char *argv[], gn_data 
*data, struct gn_sta
        gn_data_clear(data);
        memset(&calnote, 0, sizeof(gn_calnote));
        data->calnote = &calnote;
+       memset(&clist, 0, sizeof(gn_calnote_list));
        data->calnote_list = &clist;
 
        first_location = gnokii_atoi(optarg);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    2 ++
 gnokii/gnokii-calendar.c |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
libgnokii and core programs




reply via email to

[Prev in Thread] Current Thread [Next in Thread]