gnokii/common/phones atgen.c

[Daniele Forsi]

CVSROOT:        /sources/gnokii
Module name:    gnokii
Changes by:     Daniele Forsi <dforsi>  08/08/11 14:55:46

Modified files:
        common/phones  : atgen.c 

Log message:
        check that the cell id has at least 8 chars (every 4-chars cell id 
verifies
        the condition if (strlen(pos) > 4) when the trailing quotes aren't 
stripped)
        
        fixes invalid reads reported by valgrind:
        
        ==17209== Invalid read of size 1
        ==17209==    at 0x80996A1: creg_parse (atgen.c:2469)
        ==17209==    by 0x809D821: ReplyGetNetworkInfo (atgen.c:2534)
        ==17209==    by 0x805F9FB: sm_incoming_function (gsm-statemachine.c:131)
        ==17209==    by 0x80A9761: atbus_loop (atbus.c:238)
        ==17209==    by 0x805FB3F: gn_sm_loop (gsm-statemachine.c:84)
        ==17209==    by 0x805FDE4: __sm_block_timeout (gsm-statemachine.c:275)
        ==17209==    by 0x805FEB6: sm_block_no_retry (gsm-statemachine.c:317)
        ==17209==    by 0x80989D7: AT_GetNetworkInfo (atgen.c:1391)
        ==17209==    by 0x809AEA6: Functions (atgen.c:293)
        ==17209==    by 0x8053149: getnetworkinfo (gnokii-other.c:189)
        ==17209==    by 0x804C019: parse_options (gnokii.c:1035)
        ==17209==    by 0x804BC44: parse_options (gnokii.c:772)
        ==17209==  Address 0x44b9c3f is 0 bytes after a block of size 7 alloc'd
        ==17209==    at 0x4021AB8: malloc (vg_replace_malloc.c:207)
        ==17209==    by 0x4284FCF: strdup (in /lib/tls/i686/cmov/libc-2.7.so)
        ==17209==    by 0x807834B: gnokii_strsplit (misc.c:596)
        ==17209==    by 0x809D7F4: ReplyGetNetworkInfo (atgen.c:2515)
        ==17209==    by 0x805F9FB: sm_incoming_function (gsm-statemachine.c:131)
        ==17209==    by 0x80A9761: atbus_loop (atbus.c:238)
        ==17209==    by 0x805FB3F: gn_sm_loop (gsm-statemachine.c:84)
        ==17209==    by 0x805FDE4: __sm_block_timeout (gsm-statemachine.c:275)
        ==17209==    by 0x805FEB6: sm_block_no_retry (gsm-statemachine.c:317)
        ==17209==    by 0x80989D7: AT_GetNetworkInfo (atgen.c:1391)
        ==17209==    by 0x809AEA6: Functions (atgen.c:293)
        ==17209==    by 0x8053149: getnetworkinfo (gnokii-other.c:189)
        ==17209== 
        ==17209== Invalid read of size 1
        ==17209==    at 0x80996A8: creg_parse (atgen.c:2470)
        ==17209==    by 0x809D821: ReplyGetNetworkInfo (atgen.c:2534)
        ==17209==    by 0x805F9FB: sm_incoming_function (gsm-statemachine.c:131)
        ==17209==    by 0x80A9761: atbus_loop (atbus.c:238)
        ==17209==    by 0x805FB3F: gn_sm_loop (gsm-statemachine.c:84)
        ==17209==    by 0x805FDE4: __sm_block_timeout (gsm-statemachine.c:275)
        ==17209==    by 0x805FEB6: sm_block_no_retry (gsm-statemachine.c:317)
        ==17209==    by 0x80989D7: AT_GetNetworkInfo (atgen.c:1391)
        ==17209==    by 0x809AEA6: Functions (atgen.c:293)
        ==17209==    by 0x8053149: getnetworkinfo (gnokii-other.c:189)
        ==17209==    by 0x804C019: parse_options (gnokii.c:1035)
        ==17209==    by 0x804BC44: parse_options (gnokii.c:772)
        ==17209==  Address 0x44b9c40 is 1 bytes after a block of size 7 alloc'd
        ==17209==    at 0x4021AB8: malloc (vg_replace_malloc.c:207)
        ==17209==    by 0x4284FCF: strdup (in /lib/tls/i686/cmov/libc-2.7.so)
        ==17209==    by 0x807834B: gnokii_strsplit (misc.c:596)
        ==17209==    by 0x809D7F4: ReplyGetNetworkInfo (atgen.c:2515)
        ==17209==    by 0x805F9FB: sm_incoming_function (gsm-statemachine.c:131)
        ==17209==    by 0x80A9761: atbus_loop (atbus.c:238)
        ==17209==    by 0x805FB3F: gn_sm_loop (gsm-statemachine.c:84)
        ==17209==    by 0x805FDE4: __sm_block_timeout (gsm-statemachine.c:275)
        ==17209==    by 0x805FEB6: sm_block_no_retry (gsm-statemachine.c:317)
        ==17209==    by 0x80989D7: AT_GetNetworkInfo (atgen.c:1391)
        ==17209==    by 0x809AEA6: Functions (atgen.c:293)
        ==17209==    by 0x8053149: getnetworkinfo (gnokii-other.c:189)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnokii/common/phones/atgen.c?cvsroot=gnokii&r1=1.202&r2=1.203