Re: [Gnewsense-dev] patch liferea

[Marek Buras]

On Thu, Jun 13, 2013 at 03:26:16AM +0200, Anthony LETELLIER wrote:
> I forgot the patch

That happens  ;-)

> Description: Remove Opera. Replace Firefox and Mozilla by Iceweasel and 
> Iceape.
> Author: Anthony Letellier <address@hidden>
> Bug-gNewSense: https://savannah.nongnu.org/bugs/?33639
> Last-Update: 2013 06 13
> --- a/src/ui/ui_prefs.c
> +++ b/src/ui/ui_prefs.c
> @@ -76,24 +76,18 @@
>               NULL, NULL
>       },
>       {
> -             /* tested with SeaMonkey 1.0.6 */
> -             "mozilla", "Mozilla", "mozilla %s",
> -             NULL, "mozilla -remote openURL(%s)",
> -             NULL, "mozilla -remote 'openURL(%s,new-window)'",
> -             NULL, "mozilla -remote 'openURL(%s,new-tab)'"
> +             /* tested with Iceape 2.0.11 */
> +             "iceape", "Iceape", "iceape %s",
> +             NULL, "iceape -remote openURL(%s)",
> +             NULL, "iceape -remote 'openURL(%s,new-window)'",
> +             NULL, "iceape -remote 'openURL(%s,new-tab)'"
>       },
>       {
> -             /* tested with Firefox 1.5 and 2.0 */
> -             "firefox", "Firefox","firefox \"%s\"",
> -             NULL, "firefox -a firefox -remote \"openURL(%s)\"",
> -             NULL, "firefox -a firefox -remote 'openURL(%s,new-window)'",
> -             NULL, "firefox -a firefox -remote 'openURL(%s,new-tab)'"
> -     },
> -     {
> -             "opera", "Opera","opera \"%s\"",
> -             "opera \"%s\"", "opera -remote \"openURL(%s)\"",
> -             "opera -newwindow \"%s\"", NULL,
> -             "opera -newpage \"%s\"", NULL
> +             /* tested with Iceweasel 3.5.16 */
> +             "iceweasel", "Iceweasel","iceweasel \"%s\"",
> +             NULL, "iceweasel -a iceweasel -remote \"openURL(%s)\"",
> +             NULL, "iceweasel -a iceweasel -remote 'openURL(%s,new-window)'",
> +             NULL, "iceweasel -a iceweasel -remote 'openURL(%s,new-tab)'"
>       },
>       {
>               "epiphany", "Epiphany","epiphany \"%s\"",

The patch looks ok to me. Thanks for taking care of it - it was laying too
long on our bugs list.

Happy hacking!
-- 
Marek Buras
cyfr0n (at) onet.pl