Re: [Gnewsense-dev] b43 kernel module suggests installation of proprietary firmware

[Patrik Lembke]

On Thu, 6 Aug 2009 18:45:11 +0930 Karl Goetz <address@hidden> wrote:
> On Wed, 5 Aug 2009 12:28:47 +0200
> Patrik Lembke <address@hidden> wrote:
> 
> > On Wed, 5 Aug 2009 18:02:24 +0930 Karl Goetz <address@hidden>
> > wrote:
> > > Hi all, could someone with a badcom card please try and reproduce
> > > this bug[1]?
> > > 
> > > What I'm hoping to know is;
> > > - Does it happen to you
> > > - what kernel module is causing the message
> > > 
> > > [1] http://bugs.gnewsense.org/Bugs/00308
> > > kk
> > > 
> > 
> > Yes It did until I added the free firmware.
> > 
> > It is a message stored in /drivers/net/wireless/b43/main.c (in
> > 2.6.28.1 row 1998) 
> > 
> 
> Line 1572 in 2.6.24.
> 
> > KFV link
> > http://wiki.gnewsense.org/Kernel/Ubuntu-hardy-linux-2-6-24-12-22--drivers--net--wireless--b43
> > 
> > A patch for the later kernels who can use the free (2.6.28 looks like
> > it can) could be to just replace this with something nicer telling the
> > user how to install the OpenFWWF firmware.
> > 
> >  text = "You must install the openfwwf firmware, instructions can be
> >  found at NiceGnewsenseWikiPage\n";
> 
> We don't currently have such a page :(
> 

I could write one up, but not sure were in the wiki to put it :(

> > And it do look quite possible to patch the module so It won't be able
> > to load the non-free firmware.
> 
> I don't want to do that (even though Linux-libre does it).
> 
> > Just replacing what is said in main.c:2302 inside that else with
> > something similar to:
> > 
> >  b43err( dev->wl, "Sorry the firmware your trying to use is not
> >  supported since it's non-free\n" );
> >  goto error;
> 
> This is what I'm doing for my test runs - if someone makes NiceWikiPage
> before I apply the fix then we can link there instead :)
> 
> static void b43_print_fw_helptext(struct b43_wl *wl)
> {
>         b43err(wl, "Unfortunately this driver requires non-free
> firmwork to function.\n"); }
> 
> 
> kk
> 


-- 
Patrik Lembke
www: http://blambi.chebab.com/
jabber: address@hidden
GnuPG-key: http://gpg.chebab.com/8FA11A15.asc

signature.asc
Description: PGP signature