Re: [Gnash] Patch: Give error for unhandled SWF events

[Dag Hovland]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

Michael Carlson:
> Download this file : http://protu.it.helsinki.fi/~lindi/google-video.swf
> 
> Then, try opening it locally with gnash, using the "-va" command switch
> (for verbose Movie Actions). The program will crash with an assertion
> error. After some investigating, I realized that in server/impl.cpp,
> swf_event::read(), we don't do any sort of check to see if the event
> flag that was sent to us is known and handled by the program. This patch
> simply adds a log_error statement, letting you know that an event was
> received that is unknown and unhandled, the hex code of the event, as
> well as an appropriate comment in the source explaining this check.
> 
After looking at corresponding code in gplflash2 (ClipEventFlags in
lib/swf.hh), it seems that the offending event is named CONSTRUCT. From
the code in lib/swf_decoder, line 558, it seems to have been added in
swf v6, together with key_press and and drag_out, though I cannot see
this in other docs.

I have tried to do some fixing, but at the moment it still crashes on
the google-video (the "as_environment" is popped when empty), probably
because the "CONSTRUCT" has to be implemented in some way I do not know.

Dag Hovland
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDzqwhxcsAsac+K+IRApYtAJ4keJzi1CV9mornmBHp9dx9+VedfgCgxIY/
07TYjW+I4vsKniWel872YKk=
=68Vy
-----END PGP SIGNATURE-----