Re: [Gnash] Missing library checks in configure

[strk]

I'm applying these, but I found them to be too strict.
I successfully compiled gnash (no plugin) w/out linking
glut in.

See if you can find if and how the plugin build is disabled,
so you can make libglut unavailability just disable plugin
build rather then aborting all builds.

Thanks.

--strk;

On Tue, Jan 10, 2006 at 09:17:17PM +0100, J.H.M. Dassen (Ray) wrote:
> (Please Cc: responses to me - I'm not on the list)
> 
> While looking at Gnash CVS HEAD, I noticed that configure.ac does not check
> for a number of libraries that are used by Gnash and that there is a
> superfluous include that breaks builds on systems that don't have LessTif
> or Motif installed.
> 
> The attached patch tries to address these issues; please consider adding it
> to the tree.
> 
> Greetings,
> Ray
> -- 
> "I'm just waiting to see `Red Hat to acquire Abominable Snowman & Department
> of Defense in Massive Stock Swap.'"
>       Hemos in http://slashdot.org/article.pl?sid=99/12/16/1741211 

> Index: configure.ac
> ===================================================================
> RCS file: /sources/gnash/gnash/configure.ac,v
> retrieving revision 1.11
> diff -u -I'$Id.*$' -p -r1.11 configure.ac
> --- configure.ac      8 Jan 2006 18:56:27 -0000       1.11
> +++ configure.ac      10 Jan 2006 20:10:38 -0000
> @@ -28,6 +28,27 @@ AM_INIT_AUTOMAKE(gnash, 0.7)
>  AM_MAINTAINER_MODE
>  AC_PROG_MAKE_SET
>  
> +AC_CHECK_HEADER(jpeglib.h)
> +AC_CHECK_LIB(jpeg, jpeg_destroy_decompress, [],
> +  AC_MSG_ERROR([
> +Failed to link test code against the jpeg library. Maybe you need to
> +install the development files for libjpeg?
> +]))
> +
> +AC_CHECK_HEADER(png.h)
> +AC_CHECK_LIB(png, png_write_info, [],
> +  AC_MSG_ERROR([
> +Failed to link test code against the PNG library. Maybe you need to
> +install the development files for libpng?
> +]))
> +
> +AC_CHECK_HEADER(glut.h)
> +AC_CHECK_LIB(glut, glutInit, [],
> +  AC_MSG_ERROR([
> +Failed to link test code against the GLUT library. Maybe you need to
> +install the development files for libglut?
> +]))
> +
>  dnl Use the POSIX Threads library, if specified.
>  AC_ARG_ENABLE(pthreads, [  --enable-pthreads       Enable support for 
> pthreads],
>  [case "${enableval}" in
> @@ -157,6 +178,17 @@ AM_PATH_JPEG
>  AM_PATH_PNG
>  
>  AC_PATH_XTRA
> +
> +AC_CHECK_HEADER(X11/Xmu/Xmu.h)
> +LIBS_SAVE="$LIBS"
> +LIBS="$LIBS $X_LIBS"
> +AC_CHECK_LIB(Xmu, XmuCvtStringToOrientation, [],
> +  AC_MSG_ERROR([
> +Failed to link test code against the Xmu library. Maybe you need to
> +install the development files for libxmu?
> +]))
> +LIBS="$LIBS_SAVE"
> +
>  AM_PATH_SDL
>  AM_PATH_SDL_MIXER
>  AM_PATH_OPENGL
> @@ -302,4 +334,4 @@ fi
>  if test x"$nogo" = x"true"; then
>  echo ""
>    AC_MSG_ERROR([Please install required packages])
> -fi
> \ No newline at end of file
> +fi
> Index: plugin/plugin.cpp
> ===================================================================
> RCS file: /sources/gnash/gnash/plugin/plugin.cpp,v
> retrieving revision 1.6
> diff -u -I'$Id.*$' -p -r1.6 plugin.cpp
> --- plugin/plugin.cpp 7 Jan 2006 18:14:56 -0000       1.6
> +++ plugin/plugin.cpp 10 Jan 2006 20:10:38 -0000
> @@ -29,7 +29,6 @@
>  #include <unistd.h>
>  #include <stdio.h>
>  #include <stdlib.h>
> -#include <Xm/XmAll.h>
>  #include <X11/XKBlib.h>
>  #include <X11/keysym.h>
>  #include <X11/Sunkeysym.h>

> _______________________________________________
> Gnash mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/gnash


-- 

 /"\    ASCII Ribbon Campaign
 \ /    Respect for low technology.
  X     Keep e-mail messages readable by any computer system.
 / \    Keep it ASCII.