Re: [Gnash-dev] [MERGE] Misc fixes to soldumper.cpp

[Benjamin Wolsey]

> Also consider that I already provided a merge directive before
> (as issued by bzr send), maybe you could just use that once reviewed.

Indeed I had missed that. The soldumper changes are now in trunk.

> Forward declarations require more code (forward declaration +
> declaration) -> code duplication -> more maintainance burden, and keep
> the code logic separated in two distinct locations, which doesn't help
> the reader as she may have to jump to the actual definition to
> understand it.

And they also declare the content of the file in a convenient place at
the top. But I don't really care that much.

--
Yes, YouTube does work in Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil