[Gnash-commit] [patch #8752] Patch to allow `-v` command line switches to override non-zero logging verbosity specified in `.gnashrc`

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8752>

                 Summary: Patch to allow `-v` command line switches to
override non-zero logging verbosity specified in `.gnashrc`
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 23 Sep 2015 09:20:50 PM ICT
                Category: gui
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

See the attached `0001_allow-command-line-to-override-log-verbosity.patch`.

Currently, if user set logging verbosity in Gnash's Edit > Preferences dialog
(or in `~/.gnashrc`) to non-zero value, Gnash ignores `-v` option specified
on the command line.

The patch make Gnash always use verbosity level set from command line first
if `-v` option(s) are specified, and fall back to configuration file or
default
if they are not; partially fixing bug #40487.

This is done by changing the logic used in `Player.init_logfile()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/Player.cpp?id=c0e274dbcea978e5a6dc41e3faf3e0196f8660b1#n243>
to check whether the verbosity is already set to non-zero value
before considering verbosity value specified in configuration file;
if so, ignore the value from configuration file; if not, load the value
from configuration file.

Note: This patch does not provide provision for _overriding verbosity to
zero_,
and does not change the way Edit > Preferences dialog works.
(It still only displaying and saving verbosity from/to configuration file)

Gnash: 0.8.11dev (patched against git c0e274d 23-Sep-2015)
System: Debian GNU/Linux 7.0 Wheezy i386



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 23 Sep 2015 09:20:50 PM ICT  Name:
0001_allow-command-line-to-override-log-verbosity.patch  Size: 768B   By:
nachanon
Patch to allow command line switch to override configuration file-specified
verbosity
<http://savannah.gnu.org/patch/download.php?file_id=34964>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8752>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/