[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2198-g062edf6

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  062edf672abbd849a4a67447b5c3fb9f30d1a701 (commit)
      from  f341372f201dc995d2c893a8e06670f673058897 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=062edf672abbd849a4a67447b5c3fb9f30d1a701


commit 062edf672abbd849a4a67447b5c3fb9f30d1a701
Author: Sandro Santilli <address@hidden>
Date:   Fri Aug 28 19:36:41 2015 +0200

    The 'var whatever' syntax in timeline context is not a no-op.
    
    So it was found and proved by Nutchanon Wetchasit (thanks!).
    See https://savannah.gnu.org/patch/?8721

diff --git a/libcore/vm/ASHandlers.cpp b/libcore/vm/ASHandlers.cpp
index 60a3fd7..073bca5 100644
--- a/libcore/vm/ASHandlers.cpp
+++ b/libcore/vm/ASHandlers.cpp
@@ -2346,10 +2346,11 @@ ActionVar(ActionExec& thread)
         declareLocal(vm.currentCall(), name);
     }
     else {
-       IF_VERBOSE_ASCODING_ERRORS(
-           log_aserror(_("The 'var whatever' syntax in timeline context is a "
-                   "no-op."));
-       );
+        // See https://savannah.gnu.org/patch/?8721
+        as_object* this_ptr = thread.getThisPointer();
+        if (!hasOwnProperty(*this_ptr, name)) {
+            this_ptr->set_member(name, as_value());
+        }
     }
     env.drop(1);
 }
diff --git a/testsuite/actionscript.all/getvariable.as 
b/testsuite/actionscript.all/getvariable.as
index 6bab1bb..8471eb7 100644
--- a/testsuite/actionscript.all/getvariable.as
+++ b/testsuite/actionscript.all/getvariable.as
@@ -100,6 +100,8 @@ asm {
        getvariable
         setvariable
 };
+// WARNING: this fails in all versions from 5 to 8 with LNX 11,2,202,310
+//          it results undefined instead
 check_equals(checkpoint, 5.4);
 
 //---------------------------------------------------------------------
@@ -683,6 +685,13 @@ asm {
 };
 check_equals(checkpoint, 4);
 
+// Check declaration (hasOwnProperty only exists since SWF6)
+// See https://savannah.gnu.org/bugs/?45840
+#if OUTPUT_VERSION > 5
+var undefined_timeline_declared;
+check(this.hasOwnProperty('undefined_timeline_declared'));
+#endif
+
 //-----------------------------------------------------------------------
 // TODO: try use of 'with' stack
 //-----------------------------------------------------------------------
@@ -690,7 +699,7 @@ check_equals(checkpoint, 4);
 #if OUTPUT_VERSION < 6
  check_totals(52); // gnash runs +2 tests ?!
 #else
- check_totals(57); // gnash runs +2 tests ?!
+ check_totals(58); // gnash runs +2 tests ?!
 #endif
 
 #else // ndef MING_SUPPORT_ASM

-----------------------------------------------------------------------

Summary of changes:
 libcore/vm/ASHandlers.cpp                 |    9 +++++----
 testsuite/actionscript.all/getvariable.as |   11 ++++++++++-
 2 files changed, 15 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Gnash