[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8721] Patch to make `GetVariable()` return String
From: |
Nutchanon Wetchasit |
Subject: |
[Gnash-commit] [patch #8721] Patch to make `GetVariable()` return String regardless of original variable type |
Date: |
Fri, 28 Aug 2015 13:16:04 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0 |
Follow-up Comment #5, patch #8721 (project gnash):
For the behavior difference between Gnash and Flash, I have tested around
and found that this is not really caused by `as_object.get_member()`;
the function is actually working as advertised.
The problem seemed to root from the way Gnash deals with
*unassigned* `var` declaration *in timeline context*.
Excerpt from Gnash git's debug output (verbosity 2 + action error log)
when running `getvariable.html` test (file #34682):
124 ACTIONSCRIPT ERROR: The 'var whatever' syntax in timeline context is a
no-op.
This message is from the declaration of `var undefined_variable` used in
the test. This means that Gnash ignored the declaration and left the property
unset. Thus, `as_object.get_member()` reported `false` on the variable.
If the variable is declared with `var undefined_variable=undefined` instead,
`as_object.get_member()` will report the correct result.
This issue is now posted as a separate entry: bug #45840, test included.
If that bug is fixed, the proposed GetVariable() patch would automatically
give a correct output.
Gnash: 0.8.11dev (patched against git f341372 25-Aug-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386
(file #34761)
_______________________________________________________
Additional Item Attachment:
File name: 0001_return-string-from-getvariable-v2.patch Size:1 KB
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8721>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/