[Gnash-commit] [patch #8720] Patch for fixing GC-related issue in ExternalInterface registration

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8720>

                 Summary: Patch for fixing GC-related issue in
ExternalInterface registration
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 19 Aug 2015 04:39:39 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a follow-up to patch #8715 (ExternalInterface callback fix).

Both of original patches have a GC-related code that was not working as
expected <https://savannah.gnu.org/bugs/?37223#comment10>
This patch should fix the problem by moving `as_object.setReachable()` call
from `movie_root.addExternalCallback()` to
`movie_root.markReachableResources()`
which is normally responsible for this task, and run on every GC iteration.

See the attached `0003_add-externalinterface-gc-provision.patch`.
Might need a review, since I didn't know much about Gnash's GC mechanism.

Gnash: 0.8.11dev (patched against git c5b657f 17-Aug-2015) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 19 Aug 2015 04:39:39 PM ICT  Name:
0003_add-externalinterface-gc-provision.patch  Size: 2kB   By: nachanon
Patch to fix ExternalInterface's GC provision
<http://savannah.gnu.org/patch/download.php?file_id=34677>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8720>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/