[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1890-ge39dd19

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  e39dd19366050f33c5b3413ba0043aecb23c89ea (commit)
      from  608ce8e1577d2bb0bc7c6cdf726cc0be8f1200ee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=e39dd19366050f33c5b3413ba0043aecb23c89ea


commit e39dd19366050f33c5b3413ba0043aecb23c89ea
Author: Petter Reinholdtsen <address@hidden>
Date:   Mon Apr 21 18:45:11 2014 +0200

    Explain in the code why the return value of unload() is ignored.

diff --git a/libcore/movie_root.cpp b/libcore/movie_root.cpp
index efa5ddf..553d22a 100644
--- a/libcore/movie_root.cpp
+++ b/libcore/movie_root.cpp
@@ -480,6 +480,9 @@ movie_root::dropLevel(int depth)
     }
 
     // TOCHECK: safe to erase here ?
+
+    // Ignoring return value of unload(), because the only way to handle
+    // an unload failure is to call destroy, which is done anyway.
     (void)mo->unload();
     mo->destroy();
     _movies.erase(it);

-----------------------------------------------------------------------

Summary of changes:
 libcore/movie_root.cpp |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Gnash