[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1886-g2644c93

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  2644c937eaafe7a43534899511fbbd4b85946696 (commit)
      from  ef05fe0cc1b54c543f4011211b26c91e8d929833 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=2644c937eaafe7a43534899511fbbd4b85946696


commit 2644c937eaafe7a43534899511fbbd4b85946696
Author: Petter Reinholdtsen <address@hidden>
Date:   Sun Apr 20 20:22:27 2014 +0200

    Handle read errors in test code, when -1 is returned (Coverity CID 1154670,
    1154671).

diff --git a/testsuite/libbase.all/NoSeekFileTest.cpp 
b/testsuite/libbase.all/NoSeekFileTest.cpp
index 418a59b..b5afe95 100644
--- a/testsuite/libbase.all/NoSeekFileTest.cpp
+++ b/testsuite/libbase.all/NoSeekFileTest.cpp
@@ -50,10 +50,10 @@ using namespace std;
 TestState runtest;
 
 static void
-dump_buffer(const char* label, char* buf, size_t size, ostream& os)
+dump_buffer(const char* label, char* buf, ssize_t size, ostream& os)
 {
        os << label << ":" << endl;
-       for (size_t i=0; i<size; i++) {
+       for (ssize_t i=0; i<size; i++) {
                os << '[' << buf[i] << ']';
        }
 
@@ -73,8 +73,8 @@ compare_reads(gnash::IOChannel* reader, int fd, const char* 
first, const char* s
 
        for(;;)
        {
-               size_t sz1 = reader->read(buf, CHUNK_SIZE);
-               size_t sz2 = read(fd, buf2, CHUNK_SIZE);
+               ssize_t sz1 = reader->read(buf, CHUNK_SIZE);
+               ssize_t sz2 = read(fd, buf2, CHUNK_SIZE);
 
                if ( sz1 != sz2 )
                {
@@ -87,7 +87,7 @@ compare_reads(gnash::IOChannel* reader, int fd, const char* 
first, const char* s
                        return false;
                }
 
-               if ( sz1 == 0 ) {
+               if ( sz1 <= 0 ) {
                        break;
                }
 

-----------------------------------------------------------------------

Summary of changes:
 testsuite/libbase.all/NoSeekFileTest.cpp |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Gnash