[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1872-gbdc7dfe

[Bastiaan Jacques]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  bdc7dfe3fb6457a2984e4466cb6bf980ab787cfe (commit)
       via  46ec56cc24e74100778ee7144e9bddf4bb74fc83 (commit)
      from  0103ff2b88d52a28d686fa63a3f3886ddf7da773 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=bdc7dfe3fb6457a2984e4466cb6bf980ab787cfe


commit bdc7dfe3fb6457a2984e4466cb6bf980ab787cfe
Author: Bastiaan Jacques <address@hidden>
Date:   Sat Apr 19 16:01:10 2014 +0200

    Plug leaks. Coverity 1149185.

diff --git a/libcore/asobj/XML_as.cpp b/libcore/asobj/XML_as.cpp
index a361856..8ae2d36 100644
--- a/libcore/asobj/XML_as.cpp
+++ b/libcore/asobj/XML_as.cpp
@@ -311,10 +311,6 @@ XML_as::parseTag(XMLNode_as*& node, xml_iterator& it,
 
     if (!closing) {
 
-        XMLNode_as* childNode = new XMLNode_as(_global);
-        childNode->nodeNameSet(tagName);
-        childNode->nodeTypeSet(Element);
-
         // Skip to the end of any whitespace after the tag name
         it = endName;
 
@@ -323,6 +319,10 @@ XML_as::parseTag(XMLNode_as*& node, xml_iterator& it,
            return;
         }
 
+        XMLNode_as* childNode = new XMLNode_as(_global);
+        childNode->nodeNameSet(tagName);
+        childNode->nodeTypeSet(Element);
+
         // Parse any attributes in an opening tag only, stopping at "/>" or
         // '>'
         // Attributes are added in reverse order and without any duplicates.
@@ -343,7 +343,10 @@ XML_as::parseTag(XMLNode_as*& node, xml_iterator& it,
         }
         
         // Do nothing more if there was an error in attributes parsing.
-        if (_status != XML_OK) return;
+        if (_status != XML_OK) {
+            delete childNode;
+            return;
+        }
 
         // testsuite/swfdec/xml-id-map.as tests that the node is appended
         // first.

http://git.savannah.gnu.org/cgit//commit/?id=46ec56cc24e74100778ee7144e9bddf4bb74fc83


commit 46ec56cc24e74100778ee7144e9bddf4bb74fc83
Author: Bastiaan Jacques <address@hidden>
Date:   Sat Apr 19 15:56:21 2014 +0200

    Plug leak. Coverity 1149186.

diff --git a/libcore/asobj/NetStream_as.cpp b/libcore/asobj/NetStream_as.cpp
index 386a227..594e3c5 100644
--- a/libcore/asobj/NetStream_as.cpp
+++ b/libcore/asobj/NetStream_as.cpp
@@ -673,10 +673,6 @@ NetStream_as::decodeNextAudioFrame()
 {
     assert (_parser.get());
 
-    // TODO: make the buffer cursored later ?
-    BufferedAudioStreamer::CursoredBuffer* raw =
-        new BufferedAudioStreamer::CursoredBuffer();
-
 #ifdef USE_MEDIA
     std::auto_ptr<media::EncodedAudioFrame> frame = _parser->nextAudioFrame(); 
     if (!frame.get()) {
@@ -688,6 +684,10 @@ NetStream_as::decodeNextAudioFrame()
         return 0;
     }
 
+    // TODO: make the buffer cursored later ?
+    BufferedAudioStreamer::CursoredBuffer* raw =
+        new BufferedAudioStreamer::CursoredBuffer();
+
     raw->m_data = _audioDecoder->decode(*frame, raw->m_size);
 
     // TODO: let the sound_handler do this .. sounds cleaner

-----------------------------------------------------------------------

Summary of changes:
 libcore/asobj/NetStream_as.cpp |    8 ++++----
 libcore/asobj/XML_as.cpp       |   13 ++++++++-----
 2 files changed, 12 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Gnash