[Gnash-commit] [bug #39985] rtmp_msg.cpp:173: off by one error

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?39985>

                 Summary: rtmp_msg.cpp:173: off by one error
                 Project: Gnash - The GNU Flash player
            Submitted by: dcb314
            Submitted on: Sun 08 Sep 2013 09:12:29 GMT
                Category: None
                Severity: 3 - Normal
                 Release: 0.8.10
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

I just ran static analyser "cppcheck" over the source
code of gnash-0.8.10

It said

[rtmp_msg.cpp:173]: (error) When index==_amfobjs.size(), _amfobjs[index] is
out of bounds.

Source code is

    if (index <= _amfobjs.size()) {
    return _amfobjs[index];
    }

Suggest swap "<=" for "<".






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39985>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/