[Gnash-commit] [patch #8086] RTMP netStream patch

[George Thomas]

Follow-up Comment #40, patch #8086 (project gnash):

This logically looks like a mistake but I am also surprised it is working. 

The rtmp object has a Socket attribute assosciated with it which is handling
the writing to the network. 
The rtmp.call() creates the packet and writes to the socket. 

But I am surprised the initialization takes place at _rtmp.connect() which
gets called at the 
time of creation of connection. Ideally the objects used should be the same.

An error is seen in the logs.
ERROR: Socket send error Socket operation on non-socket

The problem in using the same object is that RTMPConnection is the one having
the rtmp object. So I believe the play method functionality also should go
there.

The situation is like this

RTMPConnection(_rtmp object is present there)/HTTPConnection ---> Connection
NetConnection_as  uses (Connection)
NetStream_as (has NetConnection as its member)

So the problem is the accessing the _rtmp object in NetConnection from
NetStream.

The docs for Connection class says 

/// Abstract connection handler class
//
/// This class abstract operations on network connections,
/// specifically RPC and streams fetching.
class Connection : boost::noncopyable
{
.....


So is this not the right place to have the play method as well?

netstream_play is the entry point for netstream from the actionscript as I
understand it. And this is from where the play of the netStream is actually
called.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8086>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/