[Gnash-commit] [bug #39128] gnash 0.8.10: bad C++ code in cygnal/proc.cpp

[David Binderman]

URL:
  <http://savannah.gnu.org/bugs/?39128>

                 Summary: gnash 0.8.10: bad C++ code in cygnal/proc.cpp
                 Project: Gnash - The GNU Flash player
            Submitted by: dcb314
            Submitted on: Fri 31 May 2013 16:58:05 GMT
                Category: None
                Severity: 3 - Normal
                 Release: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

//     if (dbglogfile.getVerbosity() > 0) {
    cmd_line[1] = new char(3);
    strcpy(cmd_line[1], "-n");
    cmd_line[2] = new char(4);
    strcpy(cmd_line[2], "-vv");
    cmd_line[3] = 0;
//     }

    // When running multiple cgis, we prefer to specify the port it's using.
    if (port > 0) {
        cmd_line[3] = new char(3);
        strcpy(cmd_line[3], "-p");
        cmd_line[4] = new char(10);
        sprintf(cmd_line[4], "%d", port);
        cmd_line[5] = 0;
    }

It looks to me like the ( and ) on the calls to new
should be [ and ]. Array new seems to be intended,
but initialisation of one char is actually performed.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?39128>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/