[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [bug #38244] Gnash uses a double-escaped URL to invoke xd
|
From: |
Nachanon Vetjasit |
|
Subject: |
[Gnash-commit] [bug #38244] Gnash uses a double-escaped URL to invoke xdg-open |
|
Date: |
Sat, 09 Mar 2013 09:53:09 +0000 |
|
User-agent: |
Opera/9.64 (X11; Linux i686; U; en) Presto/2.1.1 |
Follow-up Comment #5, bug #38244 (project gnash):
Added safety for Unix system:
2149c2149,2150
< std::string safeurl = url.encode(urlstr);
---
> std::string safeurl = urlstr;
> boost::replace_all(safeurl, "'", "%27");
Rationale: to prevent URL from escaping the single quote
According to RFC3986, an apostrophe is a valid URI character,
but most URL didn't use it, and browser sends it as %27.
After changing to this patch, my single-quote breaking test worked
(My GNOME Browser popped up at Apostrophe page on English Wikipedia)
29059:1] 404 DEBUG: get url: target=_blank,
URL=http://en.wikipedia.org/wiki/', method=0 (sendVars:0, loadTarget:0,
loadVariable:0)
29059:1] 405 NETWORK: getURL: HOSTFD is -1
29059:1] 405 DEBUG: Launching URL: xdg-open
'http://en.wikipedia.org/wiki/%27'
gnash: gnash-0.8.10 (Source)
system: Debian GNU/Linux 5.0 Lenny i386
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?38244>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/