[Gnash-commit] [patch #7585] Removing parse parameter from AudioDecoder interface

[Jonas 'Sortie' Termansen]

URL:
  <http://savannah.gnu.org/patch/?7585>

                 Summary: Removing parse parameter from AudioDecoder interface
                 Project: Gnash - The GNU Flash player
            Submitted by: sortie
            Submitted on: Wed 27 Jul 2011 09:45:23 PM CEST
                Category: sound
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The parse parameter used in the "uint8_t* decode(uint8_t* input, uint32_t
inputSize, uint32_t& outputSize, uint32_t& decodedData, bool parse)" function
in AudioDecoder is not needed.

Every backend but FFmpeg ignores it, and FFmpeg only uses it to log error
messages if the caller guesses the wrong value - the AudioDecoder class
figures the need automatically.

I went ahead and removed it because it is unnecessary, and that the system
actually creates problems in my upcoming libmedia testcase. Internally,
AudioDecoderFfmpeg requires a parser for any non-flash codec, but most does
not require (or even have) one. This prevents that class from loading these
media files.

In this patch, I remove the parameter, and change AudioDecoderFfmpeg to
attempt creating a parser, and if not possible, carry on regardleses. This
behavior fixes ffmpeg playback of 3 of my sample files (sample-vorbis.mkv,
sample-vorbis.webm, sample-pcm.wav).



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 27 Jul 2011 09:45:23 PM CEST  Name:
0001-Removed-parse-parameter-from-AudioDecoder-interface.patch  Size: 12kB  
By: sortie

<http://savannah.gnu.org/patch/download.php?file_id=23704>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7585>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/