Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-188-gfa14199

[Benjamin Wolsey]

Am Montag, den 07.03.2011, 20:47 +0100 schrieb Sandro Santilli:
> On Mon, Mar 07, 2011 at 03:27:05PM +0000, Benjamin Wolsey wrote:
> 
> > -    boost::intrusive_ptr<as_function> pointCtor = pointClass.to_function();
> > +    as_function* pointCtor = pointClass.to_function();
> 
> True, it was getting kind of obsoleted.
> BUT, my plan for mixing GC with RC was to still use intrusive_ptr.

There were approximately 20 places left where intrusive_ptr was still
used for GC objects, while everywhere else had raw pointers. It didn't
seem that it would save much time while refactoring, and it did nothing
to make the current state clearer!

> The idea of a gc_ptr was really to recognize where pointers
> to gc-collectables were being hold.

Yes, it might be preferable in any case to use a special type or typedef
for GC pointers so that future refactoring is simpler, and above all so
that it's clear when an allocation with new doesn't have to be managed. 

bwy


-- 
--
Free Flash, use Gnash
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog

xmpp:address@hidden
http://identi.ca/bwy

signature.asc
Description: This is a digitally signed message part