[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-143-g630938c

[Bastiaan Jacques]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  630938c5eb52921eb510192df3015ffc4395e276 (commit)
      from  c98db81ab10c605d4fc19d990fa290eaa713e858 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=630938c5eb52921eb510192df3015ffc4395e276


commit 630938c5eb52921eb510192df3015ffc4395e276
Author: Bastiaan Jacques <address@hidden>
Date:   Mon Feb 28 02:31:05 2011 +0100

    Fix unsafe access of NPString, which is not guaranteed to be 
NULL-terminated.

diff --git a/plugin/npapi/pluginScriptObject.cpp 
b/plugin/npapi/pluginScriptObject.cpp
index b9480bb..7366b4c 100644
--- a/plugin/npapi/pluginScriptObject.cpp
+++ b/plugin/npapi/pluginScriptObject.cpp
@@ -85,17 +85,6 @@ static int hostfd = -1;
 /// standalone player from this plugin.
 static int controlfd = -1;
 
-bool
-testfunc (NPObject */* npobj */, NPIdentifier /* name */, const NPVariant 
*/*args */,
-          uint32_t /* argCount */, NPVariant *result)
-{   
-    log_debug(__PRETTY_FUNCTION__);
-    
-    DOUBLE_TO_NPVARIANT(122333.4444, *result);
-    
-    return true;
-}
-
 void
 printNPVariant(const NPVariant *value)
 {
@@ -103,7 +92,7 @@ printNPVariant(const NPVariant *value)
         double num = NPVARIANT_TO_DOUBLE(*value);
         log_debug("is double, value %g", num);
     } else if (NPVARIANT_IS_STRING(*value)) {
-        std::string str(NPVARIANT_TO_STRING(*value).UTF8Characters);
+        std::string str = NPStringToString(NPVARIANT_TO_STRING(*value));
         log_debug("is string, value %s", str);
     } else if (NPVARIANT_IS_BOOLEAN(*value)) {
         bool flag = NPVARIANT_TO_BOOLEAN(*value);

-----------------------------------------------------------------------

Summary of changes:
 plugin/npapi/pluginScriptObject.cpp |   13 +------------
 1 files changed, 1 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
Gnash