[Gnash-commit] [SCM] Gnash branch, release, updated. release_0_8_9_start-33-gbc4ff4e

[Gabriele Giacone]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, release has been updated
       via  bc4ff4edeb7bf1f7a71e4f93aded4f2d3afde677 (commit)
       via  1e546e7506d677b3f582d300bb91b54062b2abf3 (commit)
      from  7b8df3c7d49c162ab06695bb7543b6e200876f29 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=bc4ff4edeb7bf1f7a71e4f93aded4f2d3afde677


commit bc4ff4edeb7bf1f7a71e4f93aded4f2d3afde677
Author: Benjamin Wolsey <address@hidden>
Date:   Wed Feb 9 16:14:17 2011 +0100

    Check number of bytes read, fix illegal access,
    explicitly construct string to avoid future bugs.
    Thanks to Sandro for noticing the access bug!

diff --git a/libcore/ExternalInterface.cpp b/libcore/ExternalInterface.cpp
index b25e2cf..f45b5da 100644
--- a/libcore/ExternalInterface.cpp
+++ b/libcore/ExternalInterface.cpp
@@ -151,14 +151,14 @@ ExternalInterface::ExternalEventCheck(int fd)
             return error;
         }
         log_debug("There are %d bytes in the network buffer", bytes);
-        boost::scoped_array<char> buffer(new char[bytes+1]);
+        boost::scoped_array<char> buffer(new char[bytes + 1]);
         // Since we know how bytes are in the network buffer, allocate
         // some memory to read the data.
         // terminate incase we want to treat the data like a string.
-        buffer[bytes+1] = 0;
+        buffer[bytes] = 0;
         const int ret = ::read(fd, buffer.get(), bytes);
-        if (ret) {
-            return parseInvoke(buffer.get());
+        if (ret > 0) {
+            return parseInvoke(std::string(buffer.get(), ret));
         }
     }
 

http://git.savannah.gnu.org/cgit//commit/?id=1e546e7506d677b3f582d300bb91b54062b2abf3


commit 1e546e7506d677b3f582d300bb91b54062b2abf3
Author: Sandro Santilli <address@hidden>
Date:   Wed Feb 9 15:26:04 2011 +0100

    Do not instanciate a BitmapFilter: it is unused and left leaking

diff --git a/libcore/asobj/flash/filters/BitmapFilter_as.cpp 
b/libcore/asobj/flash/filters/BitmapFilter_as.cpp
index 4fd8f1f..cc83012 100644
--- a/libcore/asobj/flash/filters/BitmapFilter_as.cpp
+++ b/libcore/asobj/flash/filters/BitmapFilter_as.cpp
@@ -36,17 +36,18 @@ namespace {
  
 /// This may need a reference to its owner as_object
 //
-/// TODO: is BitmapFilter GC collected?
+/// TODO: is BitmapFilter GC collected? Not currently (see libcore/Filters.h)
 class BitmapFilter_as : public Relay
 {
 public:
     BitmapFilter_as()
-        :
-        _filter(new BitmapFilter)
+        //: _filter(new BitmapFilter)
     {}
 
+    // ~BitmapFilter_as() { delete _filter; }
+
 private:
-    BitmapFilter* _filter;
+    //BitmapFilter* _filter;
 };
 
 

-----------------------------------------------------------------------

Summary of changes:
 libcore/ExternalInterface.cpp                   |    8 ++++----
 libcore/asobj/flash/filters/BitmapFilter_as.cpp |    9 +++++----
 2 files changed, 9 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
Gnash