gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] /srv/bzr/gnash/trunk r12228: Comments about wrong behavio


From: Benjamin Wolsey
Subject: [Gnash-commit] /srv/bzr/gnash/trunk r12228: Comments about wrong behaviour.
Date: Mon, 07 Jun 2010 21:30:52 +0200
User-agent: Bazaar (2.0.3)

------------------------------------------------------------
revno: 12228 [merge]
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Mon 2010-06-07 21:30:52 +0200
message:
  Comments about wrong behaviour.
modified:
  libcore/swf/DoInitActionTag.h
=== modified file 'libcore/swf/DoInitActionTag.h'
--- a/libcore/swf/DoInitActionTag.h     2010-05-20 12:17:21 +0000
+++ b/libcore/swf/DoInitActionTag.h     2010-06-07 10:05:43 +0000
@@ -81,10 +81,19 @@
             return;
         }
 
-        // Tags should only be executed for already parsed character ids.
-        //
-        // If this is true, there is no need to parse or store the tag. If
-        // it's not true, this check will have to be done at runtime.
+        // TODO: Currently, tags are only be executed for already parsed
+        // character ids. This is known to be wrong: a more accurate
+        // description is:
+        //
+        // The DoInitAction tag is executed only for characters on the stage
+        // or exported characters. It is only executed once.
+        //
+        // It's not known whether characters that were placed on the stage
+        // but then removed before the InitAction tag is encountered cause
+        // the actions to be executed.
+        //
+        // Gnash currently doesn't know which characters are on the stage, or
+        // which IDs have been exported.
         DoInitActionTag* da = new DoInitActionTag(in, m, cid);
 
         IF_VERBOSE_PARSE(


reply via email to

[Prev in Thread] Current Thread [Next in Thread]