[Gnash-commit] /srv/bzr/gnash/trunk r12217: Fix warnings in movie_root (unsigned/signed comparison, unused variable).

[Benjamin Wolsey]

------------------------------------------------------------
revno: 12217
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Fri 2010-06-04 08:55:42 +0200
message:
  Fix warnings in movie_root (unsigned/signed comparison, unused variable).
  Remove unused variables.
modified:
  libcore/movie_root.cpp

=== modified file 'libcore/movie_root.cpp'
--- a/libcore/movie_root.cpp    2010-06-02 14:18:20 +0000
+++ b/libcore/movie_root.cpp    2010-06-04 06:55:42 +0000
@@ -1851,21 +1851,18 @@
 movie_root::callExternalCallback(const std::string &name, 
                                 const std::vector<as_value> &fnargs)
 {
-    std::string empty;
 
     if (_hostfd) {
-       return empty;
+        return std::string();
     }
 
-    std::vector<std::string> args;
-    std::vector<as_value>::const_iterator it;
     std::string msg = ExternalInterface::makeInvoke(name, fnargs);
 
-    int ret = ExternalInterface::writeBrowser(_hostfd, msg);
+    const size_t ret = ExternalInterface::writeBrowser(_hostfd, msg);
     if (ret != msg.size()) {
         log_error(_("Could not write to browser fd #%d: %s"),
                  _hostfd, std::strerror(errno));
-       return std::string();
+        return std::string();
     }
 
     std::string result = ExternalInterface::readBrowser(_controlfd);
@@ -2129,7 +2126,6 @@
     }
 
     std::string requestString = request.str();
-    size_t len = requestString.length();
     // TODO: should mutex-protect this ?
     // NOTE: we are assuming the hostfd is set in blocking mode here..