[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] /srv/bzr/gnash/trunk r12197: Don't use ActiveRelay fo
From: |
Benjamin Wolsey |
Subject: |
Re: [Gnash-commit] /srv/bzr/gnash/trunk r12197: Don't use ActiveRelay for ExternalInterface. |
Date: |
Tue, 25 May 2010 22:22:36 +0200 |
> - registerBuiltinClass(where, 0, 0,
> - attachExternalInterfaceStaticInterface, uri);
> -
> - // ExternalInterface_as* ei = new ExternalInterface_as(&where);
> + where.init_destructive_property(uri, externalInterfaceConstructor, 0);
I believe ExternalInterface is not a proper class, but rather a simple
object, like Mouse, Math or Keyboard. It would probably fix a few things
to initialize it as an object. There is a convenience function
registerBuiltinObject() in Global_as.h that will quite likely handle
everything correctly.
You can drop the constructor function if this works.
Objects like this are nothing more than a collection of global
functions. They aren't supposed to be instantiated by users, so there's
no instance data.
This leads to the second point:
> + ExternalInterface_as* ptr = ensure<ThisIsNative<ExternalInterface_as>
> >(fn);
> + ptr->addRootCallback(mr);
> + return as_value(true);
Wait, I'll reply on gnash-dev.
bwy
--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/
Benjamin Wolsey, Software Developer - http://benjaminwolsey.de
C++ and Open-Source Flash blog - http://www.benjaminwolsey.de/bwysblog
xmpp:address@hidden
http://identi.ca/bwy
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil