Re: [Gnash-commit] /srv/bzr/gnash/trunk r11358: framework for htmlText/text separation

[Benjamin Wolsey]

> === modified file 'libcore/TextField.h'
> --- a/libcore/TextField.h     2009-07-31 19:46:51 +0000
> +++ b/libcore/TextField.h     2009-07-31 20:59:28 +0000
> @@ -154,9 +154,14 @@
>      /// updated.
>       void updateText(const std::string& s);
>  
> +     void updateHtmlText(const std::string& s);
> +
>       /// Return value of our text.
>       std::string get_text_value() const;
>  
> +     /// Return value of our htmlText.
> +     std::string get_htmltext_value() const;
> +

I am almost certain that the htmlText property returns a string that's
generated on demand from style information, and that setting the
htmlText property strips all the tags out after parsing them and
applying the correct style. If you look at what htmlText returns, it's
completely different from anything you set it to. And it's all in upper
case.

If that's correct, there's no need to store two strings, and it would
make the code a bit simpler.

The other thing here is that get_text_value() is a virtual method in
as_object that's used for converting objects to a string in
ActionScript. TextField overrides it to display the text it contains. It
isn't necessarily, wrong to have an equivalent get_html_text_value(),
but it looks like it's there for something different.

--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil