Re: [Gnash-commit] /srv/bzr/gnash/trunk r11293: Implemented Stage.showMenu -

[Benjamin Wolsey]

>  
> +    gint popupHandlerAlt(GtkWidget *widget, GdkEvent *event);    
> +

> +    createMenuAlt();

It seems you're assuming there are only two types of menu: the normal
one and the not shown one. That isn't the case, as the ContextMenu class
gives much more control over what is displayed, including extra items.
What's needed is a way of adding items to and removing them from the
usual menu.


> +
> +     /// This value determines whether the _popup_menu should be shown or not
> +     //bool _showMenuState;
>  };

Is this going to be used?

> +             const std::string& str = fn.arg(0).to_string();
> +             StringNoCaseEqual noCaseCompare;
> +             bool state = true;
> +             // showMenu property is a boolean who's default value is true
> +             if ( noCaseCompare(str, "false") ) {
> +                     state = false;
> +             }
> +

Is it really the case that only "false" (case insensitive) works, or is
the argument converted to bool? What about Stage.showMenu = 0 or:

o = {}
o.valueOf = function() { return false; };
Stage.showMenu = o;

>               
> +             m.setShowMenuState( state );
>               return as_value();
>       }
>  }

Is there any need to do it via movie_root? Mouse_as, for instance, calls
the interface handler directly, which saves cluttering movie_root
unnecessarily. It looks like the GUI class tracks the state of showMenu,
so I wonder what the sense is doing it in movie_root too.

bwy

--
Use Gnash, the GNU Flash Player!
http://www.gnu.org/software/gnash/

Benjamin Wolsey, Software Developer - http://benjaminwolsey.de

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil