Re: [Gnash-commit] /srv/bzr/gnash/trunk r9929: call gst_init in VideoDecoderGst constructor (for consistency with AudioDecoderGst) -- I thikn this may be saner to do in MediaHandlerGst ctor btw...

[Bastiaan Jacques]

As long as MediaHandlerGst is the only class which can construct a
*DecoderGst, then that would be good. (Perhaps this can be enforced
by making the constructors private and making MediaHandlerGst a 
friend class, or something along those lines.)

Bastiaan

On Mon, 6 Oct 2008, Sandro Santilli wrote:

>  call gst_init in VideoDecoderGst constructor (for consistency with 
> AudioDecoderGst) -- I thikn this may be saner to do in MediaHandlerGst ctor 
> btw...
=== modified file 'libmedia/gst/VideoDecoderGst.cpp'
--- a/libmedia/gst/VideoDecoderGst.cpp  2008-10-05 00:08:38 +0000
+++ b/libmedia/gst/VideoDecoderGst.cpp  2008-10-06 08:52:36 +0000
@@ -34,13 +34,17 @@
 
 VideoDecoderGst::VideoDecoderGst(GstCaps* caps)
 {
+    // init GStreamer. TODO: what about doing this in MediaHandlerGst ctor?
+    gst_init (NULL, NULL);
+
     setup(caps);
 }
 
 
 VideoDecoderGst::VideoDecoderGst(videoCodecType codec_type, int width, int 
height)
 {
-  gst_init (NULL, NULL);
+    // init GStreamer. TODO: what about doing this in MediaHandlerGst ctor?
+    gst_init (NULL, NULL);
 
   GstCaps* caps;  
   switch (codec_type) {
@@ -88,8 +92,6 @@
 void
 VideoDecoderGst::setup(GstCaps* srccaps)
 {
-    gst_init (NULL, NULL);
-
     GstCaps* sinkcaps;
  
 

_______________________________________________
Gnash-commit mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/gnash-commit