gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] /srv/bzr/gnash/trunk r9928: Don't call gstreamer function


From: Sandro Santilli
Subject: [Gnash-commit] /srv/bzr/gnash/trunk r9928: Don't call gstreamer functions before gst_init ! Fixes bug #24459.
Date: Mon, 06 Oct 2008 10:26:32 +0200
User-agent: Bazaar (1.5)

------------------------------------------------------------
revno: 9928
committer: Sandro Santilli <address@hidden>
branch nick: trunk
timestamp: Mon 2008-10-06 10:26:32 +0200
message:
  Don't call gstreamer functions before gst_init ! Fixes bug #24459.
modified:
  libmedia/gst/AudioDecoderGst.cpp
=== modified file 'libmedia/gst/AudioDecoderGst.cpp'
--- a/libmedia/gst/AudioDecoderGst.cpp  2008-10-05 00:08:38 +0000
+++ b/libmedia/gst/AudioDecoderGst.cpp  2008-10-06 08:26:32 +0000
@@ -33,6 +33,9 @@
 
 AudioDecoderGst::AudioDecoderGst(SoundInfo& info)
 {
+    // init GStreamer. TODO: what about doing this in MediaHandlerGst ctor?
+    gst_init (NULL, NULL);
+
     GstCaps* srccaps = gst_caps_new_simple ("audio/mpeg",
                "mpegversion", G_TYPE_INT, 1,
                "layer", G_TYPE_INT, 3,
@@ -46,7 +49,10 @@
 
 AudioDecoderGst::AudioDecoderGst(AudioInfo& info)
 {
-    GstCaps* srccaps;
+    // init GStreamer. TODO: what about doing this in MediaHandlerGst ctor?
+    gst_init (NULL, NULL);
+
+    GstCaps* srccaps=0;
 
     if (info.type == FLASH && info.codec == AUDIO_CODEC_MP3)
     {
@@ -92,9 +98,6 @@
 
 void AudioDecoderGst::setup(GstCaps* srccaps)
 {
-    // init GStreamer
-    gst_init (NULL, NULL);
-
     if (!srccaps) {
         throw MediaException(_("AudioDecoderGst: internal error (caps creation 
failed)"));      
     }


reply via email to

[Prev in Thread] Current Thread [Next in Thread]