gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r9516: C++ify gtk_glue_agg.


From: Bastiaan Jacques
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r9516: C++ify gtk_glue_agg.
Date: Tue, 22 Jul 2008 23:35:45 +0200 (CEST)

It isn't necessary to zero out the rendering buffer, because the
renderer must draw the entire image anyway.

Bastiaan

On Tue, 22 Jul 2008, Benjamin Wolsey wrote:

------------------------------------------------------------
revno: 9516
committer: Benjamin Wolsey <address@hidden>
branch nick: trunk
timestamp: Tue 2008-07-22 10:37:17 +0200
message:
 C++ify gtk_glue_agg.
modified:
 gui/gtk_glue_agg.cpp
 gui/gtk_glue_agg.h
   ------------------------------------------------------------
   revno: 9507.1.7
   committer: Benjamin Wolsey <address@hidden>
   branch nick: workingcopy
   timestamp: Tue 2008-07-22 10:00:17 +0200
   message:
     Use a std::string instead of const char* for the pixel format. Use a
     boost::scoped_array and operator new instead of C array and realloc,
     for the offscreen buffer, which is simpler, standard-compliant and
     exception-safe. Reallocate the buffer when it shrinks too (the number
     of reallocations could be reduced by taking the chunk size into
     account).

     Make spacing and brackets consistent throughout gtk_glue_agg.cpp.

     Catch std::bad_alloc, add TODO for what to do about it (the same problem
     existed before, as the pointer value was checked after realloc).
   modified:
     gui/gtk_glue_agg.cpp
     gui/gtk_glue_agg.h





reply via email to

[Prev in Thread] Current Thread [Next in Thread]