Re: AW: AW: AW: [Gnash-commit] buildbot failure in Gnash on gnash-win32-win2000

[Dossy Shiobara]

On 2008.04.06, Benjamin Wolsey <address@hidden> wrote:
> This is in log.cpp:
> 
> #if defined(_WIN32) && defined(WIN32)
> // Required for SYSTEMTIME definitions
> # include <windows.h>
> # include <sys/types.h>
> #endif
> 
> Are they perhaps necessary for windows?

You need to #include <time.h> on Win32.

> I'd be grateful if some with windows access could test. The buildbot
> is very useful for spotting errors, but in this case I'd rather not
> commit every unlikely attempt to fix before being able to test it.

In theory, there's a feature of Buildbot where you can "try" a patch
before committing it, likely for just this kind of scenario.  I don't
know if the "try" interface is available through the web interface, and
I actually haven't tried it myself, yet.

I'll work out the issue w/ the Win32 build later--right now, I'm
re-roofing the pool house ... almost done.


-- 
Dossy Shiobara              | address@hidden | http://dossy.org/
Panoptic Computer Network   | http://panoptic.com/
  "He realized the fastest way to change is to laugh at your own
    folly -- then you can let go and quickly move on." (p. 70)