[Gnash-commit] gnash ChangeLog server/as_value.cpp server/as_v...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/03/06 20:21:24

Modified files:
        .              : ChangeLog 
        server         : as_value.cpp as_value.h 

Log message:
        cleanup: remove the unused drop_refs and destructor (both doing 
nothing).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5832&r2=1.5833
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.cpp?cvsroot=gnash&r1=1.116&r2=1.117
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_value.h?cvsroot=gnash&r1=1.87&r2=1.88

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5832
retrieving revision 1.5833
diff -u -b -r1.5832 -r1.5833
--- ChangeLog   6 Mar 2008 20:12:21 -0000       1.5832
+++ ChangeLog   6 Mar 2008 20:21:23 -0000       1.5833
@@ -1,3 +1,8 @@
+2008-03-06 Sandro Santilli <address@hidden>
+
+       * server/as_value.{cpp,h}: cleanup: remove the unused drop_refs
+         and destructor (both doing nothing).
+
 2008-03-06 Benjamin Wolsey <address@hidden>
 
        * testsuite/swfdec/PASSING: add passing Chr tests.

Index: server/as_value.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.cpp,v
retrieving revision 1.116
retrieving revision 1.117
diff -u -b -r1.116 -r1.117
--- server/as_value.cpp 19 Feb 2008 12:06:07 -0000      1.116
+++ server/as_value.cpp 6 Mar 2008 20:21:24 -0000       1.117
@@ -671,7 +671,6 @@
 void
 as_value::set_character(character& sprite)
 {
-       drop_refs();
        m_type = MOVIECLIP;
        _value = CharacterProxy(&sprite);
 }
@@ -708,7 +707,6 @@
 as_value::convert_to_string()
 {
     std::string ns = to_string();
-    drop_refs();
     m_type = STRING;   // force type.
     _value = ns;
 }
@@ -719,7 +717,6 @@
     // Force type to string.
 {
     std::string ns = to_string_versioned(version);
-    drop_refs();
     m_type = STRING;   // force type.
     _value = ns;
 }
@@ -728,7 +725,6 @@
 void
 as_value::set_undefined()
 {
-       drop_refs();
        m_type = UNDEFINED;
        _value = boost::blank();
 }
@@ -736,7 +732,6 @@
 void
 as_value::set_null()
 {
-       drop_refs();
        m_type = NULLTYPE;
        _value = boost::blank();
 }
@@ -763,7 +758,6 @@
        }
        if (m_type != OBJECT || getObj() != obj)
        {
-               drop_refs();
                m_type = OBJECT;
                _value = boost::intrusive_ptr<as_object>(obj);
        }
@@ -780,7 +774,6 @@
 {
     if (m_type != AS_FUNCTION || getFun().get() != func)
     {
-       drop_refs();
        m_type = AS_FUNCTION;
        if (func)
        {
@@ -1188,9 +1181,6 @@
 
 as_value::as_value(boost::intrusive_ptr<as_object> obj)
        :
-       // Initialize to non-object type here,
-       // or set_as_object will call
-       // drop_ref on undefined memory !!
        m_type(UNDEFINED)
 {
        set_as_object(obj);
@@ -1419,7 +1409,6 @@
 void
 as_value::set_string(const std::string& str)
 {
-       drop_refs();
        m_type = STRING;
        _value = str;
 }
@@ -1427,7 +1416,6 @@
 void
 as_value::set_double(double val)
 {
-       drop_refs();
        m_type = NUMBER;
        _value = val;
 }
@@ -1435,7 +1423,6 @@
 void
 as_value::set_bool(bool val)
 {
-       drop_refs();
        m_type = BOOLEAN;
        _value = val;
 }
@@ -1519,19 +1506,11 @@
 
 as_value::as_value(as_object* obj)
        :
-       // Initialize to non-object type here,
-       // or set_as_object will call
-       // drop_ref on undefined memory !!
        m_type(UNDEFINED)
 {
        set_as_object(obj);
 }
 
-as_value::~as_value()
-{ 
-       drop_refs(); 
-}
-
 //-------------------------------------
 // as_value::CharacterProxy
 //-------------------------------------

Index: server/as_value.h
===================================================================
RCS file: /sources/gnash/gnash/server/as_value.h,v
retrieving revision 1.87
retrieving revision 1.88
diff -u -b -r1.87 -r1.88
--- server/as_value.h   5 Mar 2008 03:55:58 -0000       1.87
+++ server/as_value.h   6 Mar 2008 20:21:24 -0000       1.88
@@ -187,21 +187,12 @@
        /// Construct a NULL or AS_FUNCTION value
        as_value(as_function* func);
 
-       ~as_value();
-
        /// Convert numeric value to string value, following ECMA-262 
specification
        //
        /// TODO: move here some of the good comments found in the function 
definition.
        ///
        static std::string doubleToString(double val, int radix=10);
 
-       /// Drop any ref counts we have.
-       //
-       /// This happens prior to changing our value.
-       /// Useful when changing types/values.
-       ///
-       void    drop_refs() {}
-
        /// Return the primitive type of this value, as a string.
        const char* typeOf() const;