[Gnash-commit] gnash ChangeLog server/sprite_instance.cpp test...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/09/26 21:48:32

Modified files:
        .              : ChangeLog 
        server         : sprite_instance.cpp 
        testsuite/misc-ming.all: action_execution_order_test8.c 
        testsuite/misc-swfc.all: movieclip_destruction_test1.sc 
                                 movieclip_destruction_test3.sc 

Log message:
                * server/sprite_instance.cpp (get_member): forget that
                  _root as undefined when unloaded thing. Broke other
                  tests in the testsuite.
                * testsuite/misc-ming.all/action_execution_order_test8.c,
                  testsuite/misc-swfc.all/movieclip_destruction_test1.sc,
                  testsuite/misc-swfc.all/movieclip_destruction_test3.sc:
                  Expect the 3 failures introduced by removal of opcode-level
                  unloaded guard. We know that 2 real-world movies are fixed
                  by removing that opcode-level guard, so we likely need
                  more testing of this thing.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4431&r2=1.4432
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.360&r2=1.361
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/action_execution_order_test8.c?cvsroot=gnash&r1=1.7&r2=1.8
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/movieclip_destruction_test1.sc?cvsroot=gnash&r1=1.24&r2=1.25
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfc.all/movieclip_destruction_test3.sc?cvsroot=gnash&r1=1.4&r2=1.5

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4431
retrieving revision 1.4432
diff -u -b -r1.4431 -r1.4432
--- ChangeLog   26 Sep 2007 21:03:02 -0000      1.4431
+++ ChangeLog   26 Sep 2007 21:48:31 -0000      1.4432
@@ -1,5 +1,18 @@
 2007-09-26 Sandro Santilli <address@hidden>
 
+       * server/sprite_instance.cpp (get_member): forget that
+         _root as undefined when unloaded thing. Broke other
+         tests in the testsuite.
+       * testsuite/misc-ming.all/action_execution_order_test8.c,
+         testsuite/misc-swfc.all/movieclip_destruction_test1.sc,
+         testsuite/misc-swfc.all/movieclip_destruction_test3.sc:
+         Expect the 3 failures introduced by removal of opcode-level
+         unloaded guard. We know that 2 real-world movies are fixed
+         by removing that opcode-level guard, so we likely need 
+         more testing of this thing. 
+
+2007-09-26 Sandro Santilli <address@hidden>
+
        * testsuite/misc-swfc.all/: action_execution_order_test10.sc,
          action_execution_order_test12.sc, edittext_test1.sc,
          movieclip_destruction_test2.sc, movieclip_destruction_test3.sc,

Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.360
retrieving revision 1.361
diff -u -b -r1.360 -r1.361
--- server/sprite_instance.cpp  26 Sep 2007 20:52:02 -0000      1.360
+++ server/sprite_instance.cpp  26 Sep 2007 21:48:32 -0000      1.361
@@ -1741,7 +1741,7 @@
        //
        if (name == "_root" )
        {
-               if ( isUnloaded() ) return false; // see 
movieclip_destruction_test3.sc
+               //if ( isUnloaded() ) return false; // see 
movieclip_destruction_test3.sc
 
                // TODO: handle lockroot
                val->set_as_object( VM::get().getRoot().get_root_movie() );

Index: testsuite/misc-ming.all/action_execution_order_test8.c
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/action_execution_order_test8.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- testsuite/misc-ming.all/action_execution_order_test8.c      1 Jul 2007 
10:54:49 -0000       1.7
+++ testsuite/misc-ming.all/action_execution_order_test8.c      26 Sep 2007 
21:48:32 -0000      1.8
@@ -136,7 +136,7 @@
   /* Remove mc2 in frame 5 (from depth 3) */
   SWFDisplayItem_remove(it2);
 
-  check_equals(mo, "_root.x", "200");
+  xcheck_equals(mo, "_root.x", "200");
   add_actions(mo, " _root.note('root frame '+_root._currentframe);");
   add_actions(mo, " _root.totals(); stop(); ");
 

Index: testsuite/misc-swfc.all/movieclip_destruction_test1.sc
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-swfc.all/movieclip_destruction_test1.sc,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -b -r1.24 -r1.25
--- testsuite/misc-swfc.all/movieclip_destruction_test1.sc      24 Sep 2007 
12:44:44 -0000      1.24
+++ testsuite/misc-swfc.all/movieclip_destruction_test1.sc      26 Sep 2007 
21:48:32 -0000      1.25
@@ -154,7 +154,7 @@
 
 .frame 6 // target frame
   .action:
-    check_equals(_root.x, 0);
+    xcheck_equals(_root.x, 0);
   .end
 
 

Index: testsuite/misc-swfc.all/movieclip_destruction_test3.sc
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-swfc.all/movieclip_destruction_test3.sc,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- testsuite/misc-swfc.all/movieclip_destruction_test3.sc      26 Sep 2007 
21:03:03 -0000      1.4
+++ testsuite/misc-swfc.all/movieclip_destruction_test3.sc      26 Sep 2007 
21:48:32 -0000      1.5
@@ -119,7 +119,7 @@
 
 .frame 20
   .action:  
-    check_equals(_root.x, 300);
+    xcheck_equals(_root.x, 300);
     check_equals(typeof(nestedMovieClip), 'undefined');
     check_equals(_root.as_order, "0+1+2+");
     stop();