[Gnash-commit] gnash ChangeLog server/vm/ASHandlers.cpp testsu...

[Zou Lunkai]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Zou Lunkai <zoulunkai>  07/09/12 05:04:17

Modified files:
        .              : ChangeLog 
        server/vm      : ASHandlers.cpp 
        testsuite/misc-ming.all: callFunction_test.c 

Log message:
        * server/vm/ASHandlers.cpp: drop parse_path for ActionCallFunction, it's
          unnecessary and has case sensitiviness issue.
        * testsuite/misc-ming.all/callFunction_test.c: two more passes.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4276&r2=1.4277
http://cvs.savannah.gnu.org/viewcvs/gnash/server/vm/ASHandlers.cpp?cvsroot=gnash&r1=1.129&r2=1.130
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/callFunction_test.c?cvsroot=gnash&r1=1.3&r2=1.4

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4276
retrieving revision 1.4277
diff -u -b -r1.4276 -r1.4277
--- ChangeLog   11 Sep 2007 22:03:05 -0000      1.4276
+++ ChangeLog   12 Sep 2007 05:04:16 -0000      1.4277
@@ -1,3 +1,9 @@
+2007-09-12 Zou Lunkai <address@hidden>
+
+       * server/vm/ASHandlers.cpp: drop parse_path for ActionCallFunction, it's
+         unnecessary and has case sensitiviness issue.
+       * testsuite/misc-ming.all/callFunction_test.c: two more passes.
+       
 2007-09-12 Chad Musick <address@hidden>
 
        * server/as_value.cpp,h: Add exception types to as_value.

Index: server/vm/ASHandlers.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/vm/ASHandlers.cpp,v
retrieving revision 1.129
retrieving revision 1.130
diff -u -b -r1.129 -r1.130
--- server/vm/ASHandlers.cpp    11 Sep 2007 22:03:05 -0000      1.129
+++ server/vm/ASHandlers.cpp    12 Sep 2007 05:04:16 -0000      1.130
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: ASHandlers.cpp,v 1.129 2007/09/11 22:03:05 cmusick Exp $ */
+/* $Id: ASHandlers.cpp,v 1.130 2007/09/12 05:04:16 zoulunkai Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -2417,15 +2417,9 @@
 
        // Let's consider it a as a string and lookup the function.
         const std::string& funcname = env.top(0).to_string(&env);
-
-        as_value function;
-
         as_object* this_ptr = thread.getThisPointer();
-        if ( ! env.parse_path(funcname, &this_ptr, function) )
-        {
-                //function = thread.getVariable(funcname);
-                function = thread.getVariable(funcname, &this_ptr);
-        }
+
+    as_value function = thread.getVariable(funcname, &this_ptr);
 
        if ( ! function.is_object() )
        {

Index: testsuite/misc-ming.all/callFunction_test.c
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/callFunction_test.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- testsuite/misc-ming.all/callFunction_test.c 1 Jul 2007 10:54:50 -0000       
1.3
+++ testsuite/misc-ming.all/callFunction_test.c 12 Sep 2007 05:04:16 -0000      
1.4
@@ -146,11 +146,11 @@
   //
   check_equals(mo, "_root.x1", "1");
   check_equals(mo, "_root.x2", "_root.mc1.mc11");
-  xcheck_equals(mo, "_root.x3", "1");
+  check_equals(mo, "_root.x3", "1");
   check_equals(mo, "_root.x4", "0");
   xcheck_equals(mo, "_root.x5", "1");
   xcheck_equals(mo, "_root.x6", "_root.mc1");
-  xcheck_equals(mo, "_root.x7", "1");
+  check_equals(mo, "_root.x7", "1");
   xcheck_equals(mo, "_root.x8", "1");
   
   add_actions(mo, " _root.totals(); stop(); ");