[Gnash-commit] gnash ChangeLog server/array.h server/vm/fn_call.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/08/30 01:02:50

Modified files:
        .              : ChangeLog 
        server         : array.h 
        server/vm      : fn_call.h 

Log message:
                * server/array.h: document the push method, use some typedefs 
for
                  semplicity (iterators).
                * server/vm/fn_call.h: add string-returning dump_args().

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4157&r2=1.4158
http://cvs.savannah.gnu.org/viewcvs/gnash/server/array.h?cvsroot=gnash&r1=1.32&r2=1.33
http://cvs.savannah.gnu.org/viewcvs/gnash/server/vm/fn_call.h?cvsroot=gnash&r1=1.10&r2=1.11

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4157
retrieving revision 1.4158
diff -u -b -r1.4157 -r1.4158
--- ChangeLog   29 Aug 2007 23:29:53 -0000      1.4157
+++ ChangeLog   30 Aug 2007 01:02:49 -0000      1.4158
@@ -1,3 +1,9 @@
+2007-08-30 Sandro Santilli <address@hidden>
+
+       * server/array.h: document the push method, use some typedefs for
+         semplicity (iterators).
+       * server/vm/fn_call.h: add string-returning dump_args().
+
 2007-08-30 Markus Gothe <address@hidden>
 
        * configure.ac, libbase/utility.h, server/asobj/Date.cpp,

Index: server/array.h
===================================================================
RCS file: /sources/gnash/gnash/server/array.h,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -b -r1.32 -r1.33
--- server/array.h      3 Aug 2007 21:10:19 -0000       1.32
+++ server/array.h      30 Aug 2007 01:02:49 -0000      1.33
@@ -55,6 +55,12 @@
 
 public:
 
+       typedef std::deque<as_value> container;
+
+       typedef container::const_iterator const_iterator;
+       typedef container::iterator iterator;
+
+
        /// Sort flags
        enum SortFlags {
 
@@ -87,10 +93,15 @@
 
        std::deque<indexed_as_value> get_indexed_elements();
 
-       std::deque<as_value>::const_iterator begin();
+       const_iterator begin();
 
-       std::deque<as_value>::const_iterator end();
+       const_iterator end();
 
+       /// Push an element to the end of the array
+       //
+       /// @param val
+       ///     The element to add 
+       ///
        void push(const as_value& val);
 
        void unshift(const as_value& val);
@@ -276,8 +287,6 @@
 
 private:
 
-       typedef std::deque<as_value> container;
-
        container elements;
 
        // this function is used internally by set_member and get_member

Index: server/vm/fn_call.h
===================================================================
RCS file: /sources/gnash/gnash/server/vm/fn_call.h,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- server/vm/fn_call.h 1 Jul 2007 10:54:37 -0000       1.10
+++ server/vm/fn_call.h 30 Aug 2007 01:02:49 -0000      1.11
@@ -32,6 +32,7 @@
 
 #include <cassert> // for inlines (arg)
 #include <ostream> // for inlines (dump_args)
+#include <sstream> // for inlines (dump_args)
 
 namespace gnash {
 
@@ -108,6 +109,14 @@
                }
        }
 
+       /// Return arguments as a string (for debugging)
+       std::string dump_args() const
+       {
+               std::stringstream ss;
+               dump_args(ss);
+               return ss.str();
+       }
+
 private:
        /// The ActionScript environment in which the function call is taking
        /// place. This contains, among other things, the function arguments.